* [PATCH 0/2] drm/panel: simple: add Innolux G070ACE-LH3
@ 2024-07-12 11:05 Steffen Trumtrar
2024-07-12 11:05 ` [PATCH 1/2] dt-bindings: display: simple: Document support for " Steffen Trumtrar
2024-07-12 11:05 ` [PATCH 2/2] drm/panel: simple: add Innolux G070ACE-LH3 LVDS display support Steffen Trumtrar
0 siblings, 2 replies; 5+ messages in thread
From: Steffen Trumtrar @ 2024-07-12 11:05 UTC (permalink / raw)
To: Neil Armstrong, Jessica Zhang, Sam Ravnborg, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Daniel Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thierry Reding
Cc: dri-devel, devicetree, linux-kernel, Steffen Trumtrar, kernel
This series adds support for the Innolux G070ACE-LH3 to the panel-simple
driver and adds the according compatible to the devicetree bindings.
Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
---
Steffen Trumtrar (2):
dt-bindings: display: simple: Document support for Innolux G070ACE-LH3
drm/panel: simple: add Innolux G070ACE-LH3 LVDS display support
.../bindings/display/panel/panel-simple.yaml | 2 ++
drivers/gpu/drm/panel/panel-simple.c | 35 ++++++++++++++++++++++
2 files changed, 37 insertions(+)
---
base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0
change-id: 20240712-b4-v6-10-topic-innolux-3f0ef0fed4b1
Best regards,
--
Steffen Trumtrar <s.trumtrar@pengutronix.de>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 1/2] dt-bindings: display: simple: Document support for Innolux G070ACE-LH3 2024-07-12 11:05 [PATCH 0/2] drm/panel: simple: add Innolux G070ACE-LH3 Steffen Trumtrar @ 2024-07-12 11:05 ` Steffen Trumtrar 2024-07-12 13:46 ` Conor Dooley 2024-07-12 11:05 ` [PATCH 2/2] drm/panel: simple: add Innolux G070ACE-LH3 LVDS display support Steffen Trumtrar 1 sibling, 1 reply; 5+ messages in thread From: Steffen Trumtrar @ 2024-07-12 11:05 UTC (permalink / raw) To: Neil Armstrong, Jessica Zhang, Sam Ravnborg, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thierry Reding Cc: dri-devel, devicetree, linux-kernel, Steffen Trumtrar, kernel Add Innolux G070ACE-LH3 7" WVGA (800x480) TFT LCD panel compatible string. Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> --- Documentation/devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml index 5067f5c0a2723..e9941a077a20d 100644 --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml @@ -180,6 +180,8 @@ properties: - innolux,at070tn92 # Innolux G070ACE-L01 7" WVGA (800x480) TFT LCD panel - innolux,g070ace-l01 + # Innolux G070ACE-LH3 7" WVGA (800x480) TFT LCD panel with WLED backlight + - innolux,g070ace-lh3 # Innolux G070Y2-L01 7" WVGA (800x480) TFT LCD panel - innolux,g070y2-l01 # Innolux G070Y2-T02 7" WVGA (800x480) TFT LCD TTL panel -- 2.45.1 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] dt-bindings: display: simple: Document support for Innolux G070ACE-LH3 2024-07-12 11:05 ` [PATCH 1/2] dt-bindings: display: simple: Document support for " Steffen Trumtrar @ 2024-07-12 13:46 ` Conor Dooley 0 siblings, 0 replies; 5+ messages in thread From: Conor Dooley @ 2024-07-12 13:46 UTC (permalink / raw) To: Steffen Trumtrar Cc: Neil Armstrong, Jessica Zhang, Sam Ravnborg, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thierry Reding, dri-devel, devicetree, linux-kernel, kernel [-- Attachment #1: Type: text/plain, Size: 267 bytes --] On Fri, Jul 12, 2024 at 01:05:55PM +0200, Steffen Trumtrar wrote: > Add Innolux G070ACE-LH3 7" WVGA (800x480) TFT LCD panel compatible string. > > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> Acked-by: Conor Dooley <conor.dooley@microchip.com> [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] drm/panel: simple: add Innolux G070ACE-LH3 LVDS display support 2024-07-12 11:05 [PATCH 0/2] drm/panel: simple: add Innolux G070ACE-LH3 Steffen Trumtrar 2024-07-12 11:05 ` [PATCH 1/2] dt-bindings: display: simple: Document support for " Steffen Trumtrar @ 2024-07-12 11:05 ` Steffen Trumtrar 2024-07-12 21:03 ` Jessica Zhang 1 sibling, 1 reply; 5+ messages in thread From: Steffen Trumtrar @ 2024-07-12 11:05 UTC (permalink / raw) To: Neil Armstrong, Jessica Zhang, Sam Ravnborg, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thierry Reding Cc: dri-devel, devicetree, linux-kernel, Steffen Trumtrar, kernel The G070ACE-LH3 is a 7" TFT Color LCD module with WLED backlight. https://www.data-modul.com/sites/default/files/products/G070ACE-LH3-specification-12058417.pdf Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> --- drivers/gpu/drm/panel/panel-simple.c | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index dcb6d0b6ced06..d3ce78643fd86 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -2509,6 +2509,38 @@ static const struct panel_desc innolux_g070y2_l01 = { .connector_type = DRM_MODE_CONNECTOR_LVDS, }; +static const struct display_timing innolux_g070ace_lh3_timing = { + .pixelclock = { 25200000, 25400000, 35700000 }, + .hactive = { 800, 800, 800 }, + .hfront_porch = { 32, 32, 32 }, + .hback_porch = { 31, 31, 31 }, + .hsync_len = { 1, 1, 1 }, + .vactive = { 480, 480, 480 }, + .vfront_porch = { 5, 5, 5 }, + .vback_porch = { 4, 4, 4 }, + .vsync_len = { 1, 1, 1 }, + .flags = DISPLAY_FLAGS_DE_HIGH, +}; + +static const struct panel_desc innolux_g070ace_lh3 = { + .timings = &innolux_g070ace_lh3_timing, + .num_timings = 1, + .bpc = 8, + .size = { + .width = 152, + .height = 91, + }, + .delay = { + .prepare = 10, + .enable = 450, + .disable = 200, + .unprepare = 510, + }, + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG, + .bus_flags = DRM_BUS_FLAG_DE_HIGH, + .connector_type = DRM_MODE_CONNECTOR_LVDS, +}; + static const struct drm_display_mode innolux_g070y2_t02_mode = { .clock = 33333, .hdisplay = 800, @@ -4599,6 +4631,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "innolux,g070ace-l01", .data = &innolux_g070ace_l01, + }, { + .compatible = "innolux,g070ace-lh3", + .data = &innolux_g070ace_lh3, }, { .compatible = "innolux,g070y2-l01", .data = &innolux_g070y2_l01, -- 2.45.1 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] drm/panel: simple: add Innolux G070ACE-LH3 LVDS display support 2024-07-12 11:05 ` [PATCH 2/2] drm/panel: simple: add Innolux G070ACE-LH3 LVDS display support Steffen Trumtrar @ 2024-07-12 21:03 ` Jessica Zhang 0 siblings, 0 replies; 5+ messages in thread From: Jessica Zhang @ 2024-07-12 21:03 UTC (permalink / raw) To: Steffen Trumtrar, Neil Armstrong, Sam Ravnborg, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Daniel Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thierry Reding Cc: dri-devel, devicetree, linux-kernel, kernel On 7/12/2024 4:05 AM, Steffen Trumtrar wrote: > The G070ACE-LH3 is a 7" TFT Color LCD module with WLED backlight. > > https://www.data-modul.com/sites/default/files/products/G070ACE-LH3-specification-12058417.pdf > > Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> > --- > drivers/gpu/drm/panel/panel-simple.c | 35 +++++++++++++++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index dcb6d0b6ced06..d3ce78643fd86 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -2509,6 +2509,38 @@ static const struct panel_desc innolux_g070y2_l01 = { > .connector_type = DRM_MODE_CONNECTOR_LVDS, > }; > > +static const struct display_timing innolux_g070ace_lh3_timing = { > + .pixelclock = { 25200000, 25400000, 35700000 }, > + .hactive = { 800, 800, 800 }, > + .hfront_porch = { 32, 32, 32 }, > + .hback_porch = { 31, 31, 31 }, > + .hsync_len = { 1, 1, 1 }, Hi Steffen, The min/max horizontal and vertical porches here don't seem to add up to the min/max [HV]blanks specified in the datasheet linked in the commit msg. Any reason for that? Thanks, Jessica Zhang > + .vactive = { 480, 480, 480 }, > + .vfront_porch = { 5, 5, 5 }, > + .vback_porch = { 4, 4, 4 }, > + .vsync_len = { 1, 1, 1 }, > + .flags = DISPLAY_FLAGS_DE_HIGH, > +}; > + > +static const struct panel_desc innolux_g070ace_lh3 = { > + .timings = &innolux_g070ace_lh3_timing, > + .num_timings = 1, > + .bpc = 8, > + .size = { > + .width = 152, > + .height = 91, > + }, > + .delay = { > + .prepare = 10, > + .enable = 450, > + .disable = 200, > + .unprepare = 510, > + }, > + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH, > + .connector_type = DRM_MODE_CONNECTOR_LVDS, > +}; > + > static const struct drm_display_mode innolux_g070y2_t02_mode = { > .clock = 33333, > .hdisplay = 800, > @@ -4599,6 +4631,9 @@ static const struct of_device_id platform_of_match[] = { > }, { > .compatible = "innolux,g070ace-l01", > .data = &innolux_g070ace_l01, > + }, { > + .compatible = "innolux,g070ace-lh3", > + .data = &innolux_g070ace_lh3, > }, { > .compatible = "innolux,g070y2-l01", > .data = &innolux_g070y2_l01, > > -- > 2.45.1 > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-07-12 21:03 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2024-07-12 11:05 [PATCH 0/2] drm/panel: simple: add Innolux G070ACE-LH3 Steffen Trumtrar 2024-07-12 11:05 ` [PATCH 1/2] dt-bindings: display: simple: Document support for " Steffen Trumtrar 2024-07-12 13:46 ` Conor Dooley 2024-07-12 11:05 ` [PATCH 2/2] drm/panel: simple: add Innolux G070ACE-LH3 LVDS display support Steffen Trumtrar 2024-07-12 21:03 ` Jessica Zhang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®