* [PATCH] MEDIA: USB: UVC: Corrected Errors in Macro Definitions
@ 2024-07-13 11:08 aditya-chari25
2024-07-13 11:27 ` Christophe JAILLET
0 siblings, 1 reply; 2+ messages in thread
From: aditya-chari25 @ 2024-07-13 11:08 UTC (permalink / raw)
To: laurent.pinchart, mchehab; +Cc: linux-media, linux-kernel, aditya-chari25
macro definitions had errors since they weren't enclosed in parenthesis
hence I rectified those errors
Signed-off-by: aditya-chari25 <adi25charis@gmail.com>
---
drivers/media/usb/uvc/uvc_driver.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
index 8fe24c98087e..6e14b9dc3886 100644
--- a/drivers/media/usb/uvc/uvc_driver.c
+++ b/drivers/media/usb/uvc/uvc_driver.c
@@ -2424,9 +2424,9 @@ static const struct uvc_device_info uvc_quirk_force_y8 = {
.quirks = UVC_QUIRK_FORCE_Y8,
};
-#define UVC_INFO_QUIRK(q) (kernel_ulong_t)&(struct uvc_device_info){.quirks = q}
-#define UVC_INFO_META(m) (kernel_ulong_t)&(struct uvc_device_info) \
- {.meta_format = m}
+#define UVC_INFO_QUIRK(q) {(kernel_ulong_t)&(struct uvc_device_info){.quirks = q}}
+#define UVC_INFO_META(m) {(kernel_ulong_t)&(struct uvc_device_info) \
+ {.meta_format = m}}
/*
* The Logitech cameras listed below have their interface class set to
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] MEDIA: USB: UVC: Corrected Errors in Macro Definitions
2024-07-13 11:08 [PATCH] MEDIA: USB: UVC: Corrected Errors in Macro Definitions aditya-chari25
@ 2024-07-13 11:27 ` Christophe JAILLET
0 siblings, 0 replies; 2+ messages in thread
From: Christophe JAILLET @ 2024-07-13 11:27 UTC (permalink / raw)
To: aditya-chari25, laurent.pinchart, mchehab; +Cc: linux-media, linux-kernel
Le 13/07/2024 à 13:08, aditya-chari25 a écrit :
> macro definitions had errors since they weren't enclosed in parenthesis
> hence I rectified those errors
Hi,
The driver does *not* compile anymore with this patch.
Can you elaborate on what you are trying to fix and if your chnage is at
least compile-tested?
CJ
>
> Signed-off-by: aditya-chari25 <adi25charis@gmail.com>
> ---
> drivers/media/usb/uvc/uvc_driver.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index 8fe24c98087e..6e14b9dc3886 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -2424,9 +2424,9 @@ static const struct uvc_device_info uvc_quirk_force_y8 = {
> .quirks = UVC_QUIRK_FORCE_Y8,
> };
>
> -#define UVC_INFO_QUIRK(q) (kernel_ulong_t)&(struct uvc_device_info){.quirks = q}
> -#define UVC_INFO_META(m) (kernel_ulong_t)&(struct uvc_device_info) \
> - {.meta_format = m}
> +#define UVC_INFO_QUIRK(q) {(kernel_ulong_t)&(struct uvc_device_info){.quirks = q}}
> +#define UVC_INFO_META(m) {(kernel_ulong_t)&(struct uvc_device_info) \
> + {.meta_format = m}}
>
> /*
> * The Logitech cameras listed below have their interface class set to
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-13 17:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-13 11:08 [PATCH] MEDIA: USB: UVC: Corrected Errors in Macro Definitions aditya-chari25
2024-07-13 11:27 ` Christophe JAILLET
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®