From: Conor Dooley <conor@kernel.org>
To: Doug Anderson <dianders@google.com>
Cc: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com>,
dmitry.torokhov@gmail.com, robh@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
jikos@kernel.org, benjamin.tissoires@redhat.co,
linus.walleij@linaro.org, hsinyi@google.com,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: HID: i2c-hid: elan: Introduce Elan ekth6a12nay
Date: Mon, 15 Jul 2024 15:31:18 +0100 [thread overview]
Message-ID: <20240715-bunkhouse-freeness-c4367d3c298d@spud> (raw)
In-Reply-To: <CAD=FV=VHDksKiZXrauiipa3HjtK4sE5+dbmXmVfhFoM-RKQP6A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1362 bytes --]
On Mon, Jul 15, 2024 at 07:22:30AM -0700, Doug Anderson wrote:
> Hi,
>
> On Mon, Jul 15, 2024 at 12:32 AM Zhaoxiong Lv
> <lvzhaoxiong@huaqin.corp-partner.google.com> wrote:
> >
> > The Elan ekth6a12nay touch screen chip same as Elan eKTH6915 controller
> > has a reset gpio. The difference is that they have different
> > post_power_delay_ms.
> >
> > Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com>
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
>
> FWIW things have changed enough between V1 and V2 that you probably
> should have removed Conor's "Acked-by" tag here and waited for him to
> re-add it.
Yeah, good spot. I wouldn't have acked this version would asking
questions - in v1 it made sense not to have a fallback when "they have a
different post power delay ms", but now there is a fallback. Is the
fallback actually suitable here, or might it be a naive rebase? Does the
ekth6a12nay work with the ekth6915's reset timing?
Thanks,
Conor.
>
> I'd also note that when posting a patch your Signed-off-by should
> always be at the bottom of any collected tags. For reference [1].
>
> [1] https://lore.kernel.org/tools/20221031165842.vxr4kp6h7qnkc53l@meerkat.local/
>
> That being said, the new binding seems OK to me.
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-07-15 14:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 7:31 [PATCH v2 0/2] HID: i2c-hid: elan: Add elan-ekth6a12nay timing Zhaoxiong Lv
2024-07-15 7:31 ` [PATCH v2 1/2] dt-bindings: HID: i2c-hid: elan: Introduce Elan ekth6a12nay Zhaoxiong Lv
2024-07-15 14:22 ` Doug Anderson
2024-07-15 14:31 ` Conor Dooley [this message]
2024-07-15 14:34 ` Doug Anderson
2024-07-15 14:32 ` Doug Anderson
2024-07-15 7:31 ` [PATCH v2 2/2] HID: i2c-hid: elan: Add elan-ekth6a12nay timing Zhaoxiong Lv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240715-bunkhouse-freeness-c4367d3c298d@spud \
--to=conor@kernel.org \
--cc=benjamin.tissoires@redhat.co \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@google.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hsinyi@google.com \
--cc=jikos@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvzhaoxiong@huaqin.corp-partner.google.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®