* [PATCH v2 0/2] HID: i2c-hid: elan: Add elan-ekth6a12nay timing @ 2024-07-15 7:31 Zhaoxiong Lv 2024-07-15 7:31 ` [PATCH v2 1/2] dt-bindings: HID: i2c-hid: elan: Introduce Elan ekth6a12nay Zhaoxiong Lv 2024-07-15 7:31 ` [PATCH v2 2/2] HID: i2c-hid: elan: Add elan-ekth6a12nay timing Zhaoxiong Lv 0 siblings, 2 replies; 7+ messages in thread From: Zhaoxiong Lv @ 2024-07-15 7:31 UTC (permalink / raw) To: dmitry.torokhov, robh, krzysztof.kozlowski+dt, conor+dt, jikos, benjamin.tissoires, linus.walleij, dianders, hsinyi Cc: dri-devel, devicetree, linux-kernel, Zhaoxiong Lv Elan-ekth6a12nay requires reset to pull down time greater than 10ms, so the configuration post_power_delay_ms is 10, and the chipset initial time is required to be greater than 300ms, so the post_gpio_reset_on_delay_ms is set to 300. Changes between V6 and V5: - PATCH 1/2: Respin the series on top of v6.10. - PATCH 2/2: No changes. - Link to v1: https://lore.kernel.org/all/20240704072958.27876-1-lvzhaoxiong@huaqin.corp-partner.google.com/ Zhaoxiong Lv (2): dt-bindings: HID: i2c-hid: elan: Introduce Elan ekth6a12nay HID: i2c-hid: elan: Add elan-ekth6a12nay timing .../devicetree/bindings/input/elan,ekth6915.yaml | 1 + drivers/hid/i2c-hid/i2c-hid-of-elan.c | 8 ++++++++ 2 files changed, 9 insertions(+) -- 2.17.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 1/2] dt-bindings: HID: i2c-hid: elan: Introduce Elan ekth6a12nay 2024-07-15 7:31 [PATCH v2 0/2] HID: i2c-hid: elan: Add elan-ekth6a12nay timing Zhaoxiong Lv @ 2024-07-15 7:31 ` Zhaoxiong Lv 2024-07-15 14:22 ` Doug Anderson 2024-07-15 7:31 ` [PATCH v2 2/2] HID: i2c-hid: elan: Add elan-ekth6a12nay timing Zhaoxiong Lv 1 sibling, 1 reply; 7+ messages in thread From: Zhaoxiong Lv @ 2024-07-15 7:31 UTC (permalink / raw) To: dmitry.torokhov, robh, krzysztof.kozlowski+dt, conor+dt, jikos, benjamin.tissoires, linus.walleij, dianders, hsinyi Cc: dri-devel, devicetree, linux-kernel, Zhaoxiong Lv The Elan ekth6a12nay touch screen chip same as Elan eKTH6915 controller has a reset gpio. The difference is that they have different post_power_delay_ms. Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com> Acked-by: Conor Dooley <conor.dooley@microchip.com> --- Changes between V2 and V1: - 1. Respin the series on top of v6.10. v1: https://lore.kernel.org/all/20240704085555.11204-2-lvzhaoxiong@huaqin.corp-partner.google.com/ --- Documentation/devicetree/bindings/input/elan,ekth6915.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml index a62916d07a08..bb5910460811 100644 --- a/Documentation/devicetree/bindings/input/elan,ekth6915.yaml +++ b/Documentation/devicetree/bindings/input/elan,ekth6915.yaml @@ -22,6 +22,7 @@ properties: - items: - enum: - elan,ekth5015m + - elan,ekth6a12nay - const: elan,ekth6915 - const: elan,ekth6915 -- 2.17.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: HID: i2c-hid: elan: Introduce Elan ekth6a12nay 2024-07-15 7:31 ` [PATCH v2 1/2] dt-bindings: HID: i2c-hid: elan: Introduce Elan ekth6a12nay Zhaoxiong Lv @ 2024-07-15 14:22 ` Doug Anderson 2024-07-15 14:31 ` Conor Dooley 2024-07-15 14:32 ` Doug Anderson 0 siblings, 2 replies; 7+ messages in thread From: Doug Anderson @ 2024-07-15 14:22 UTC (permalink / raw) To: Zhaoxiong Lv Cc: dmitry.torokhov, robh, krzysztof.kozlowski+dt, conor+dt, jikos, benjamin.tissoires, linus.walleij, hsinyi, dri-devel, devicetree, linux-kernel Hi, On Mon, Jul 15, 2024 at 12:32 AM Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com> wrote: > > The Elan ekth6a12nay touch screen chip same as Elan eKTH6915 controller > has a reset gpio. The difference is that they have different > post_power_delay_ms. > > Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com> > Acked-by: Conor Dooley <conor.dooley@microchip.com> FWIW things have changed enough between V1 and V2 that you probably should have removed Conor's "Acked-by" tag here and waited for him to re-add it. I'd also note that when posting a patch your Signed-off-by should always be at the bottom of any collected tags. For reference [1]. [1] https://lore.kernel.org/tools/20221031165842.vxr4kp6h7qnkc53l@meerkat.local/ That being said, the new binding seems OK to me. Reviewed-by: Douglas Anderson <dianders@chromium.org> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: HID: i2c-hid: elan: Introduce Elan ekth6a12nay 2024-07-15 14:22 ` Doug Anderson @ 2024-07-15 14:31 ` Conor Dooley 2024-07-15 14:34 ` Doug Anderson 2024-07-15 14:32 ` Doug Anderson 1 sibling, 1 reply; 7+ messages in thread From: Conor Dooley @ 2024-07-15 14:31 UTC (permalink / raw) To: Doug Anderson Cc: Zhaoxiong Lv, dmitry.torokhov, robh, krzysztof.kozlowski+dt, conor+dt, jikos, benjamin.tissoires, linus.walleij, hsinyi, dri-devel, devicetree, linux-kernel [-- Attachment #1: Type: text/plain, Size: 1362 bytes --] On Mon, Jul 15, 2024 at 07:22:30AM -0700, Doug Anderson wrote: > Hi, > > On Mon, Jul 15, 2024 at 12:32 AM Zhaoxiong Lv > <lvzhaoxiong@huaqin.corp-partner.google.com> wrote: > > > > The Elan ekth6a12nay touch screen chip same as Elan eKTH6915 controller > > has a reset gpio. The difference is that they have different > > post_power_delay_ms. > > > > Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com> > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > FWIW things have changed enough between V1 and V2 that you probably > should have removed Conor's "Acked-by" tag here and waited for him to > re-add it. Yeah, good spot. I wouldn't have acked this version would asking questions - in v1 it made sense not to have a fallback when "they have a different post power delay ms", but now there is a fallback. Is the fallback actually suitable here, or might it be a naive rebase? Does the ekth6a12nay work with the ekth6915's reset timing? Thanks, Conor. > > I'd also note that when posting a patch your Signed-off-by should > always be at the bottom of any collected tags. For reference [1]. > > [1] https://lore.kernel.org/tools/20221031165842.vxr4kp6h7qnkc53l@meerkat.local/ > > That being said, the new binding seems OK to me. > > Reviewed-by: Douglas Anderson <dianders@chromium.org> [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: HID: i2c-hid: elan: Introduce Elan ekth6a12nay 2024-07-15 14:31 ` Conor Dooley @ 2024-07-15 14:34 ` Doug Anderson 0 siblings, 0 replies; 7+ messages in thread From: Doug Anderson @ 2024-07-15 14:34 UTC (permalink / raw) To: Conor Dooley Cc: Zhaoxiong Lv, dmitry.torokhov, robh, krzysztof.kozlowski+dt, conor+dt, jikos, linus.walleij, hsinyi, dri-devel, devicetree, linux-kernel, Benjamin Tissoires Hi, On Mon, Jul 15, 2024 at 7:31 AM Conor Dooley <conor@kernel.org> wrote: > > On Mon, Jul 15, 2024 at 07:22:30AM -0700, Doug Anderson wrote: > > Hi, > > > > On Mon, Jul 15, 2024 at 12:32 AM Zhaoxiong Lv > > <lvzhaoxiong@huaqin.corp-partner.google.com> wrote: > > > > > > The Elan ekth6a12nay touch screen chip same as Elan eKTH6915 controller > > > has a reset gpio. The difference is that they have different > > > post_power_delay_ms. > > > > > > Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com> > > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > > > FWIW things have changed enough between V1 and V2 that you probably > > should have removed Conor's "Acked-by" tag here and waited for him to > > re-add it. > > Yeah, good spot. I wouldn't have acked this version would asking > questions - in v1 it made sense not to have a fallback when "they have a > different post power delay ms", but now there is a fallback. Is the > fallback actually suitable here, or might it be a naive rebase? Does the > ekth6a12nay work with the ekth6915's reset timing? Oh, good point! Yeah, it should be changed so that "ekth6915" isn't a fallback. ...so I will rescind my Reviewed-by until that's handled. :-/ -Doug ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: HID: i2c-hid: elan: Introduce Elan ekth6a12nay 2024-07-15 14:22 ` Doug Anderson 2024-07-15 14:31 ` Conor Dooley @ 2024-07-15 14:32 ` Doug Anderson 1 sibling, 0 replies; 7+ messages in thread From: Doug Anderson @ 2024-07-15 14:32 UTC (permalink / raw) To: Zhaoxiong Lv Cc: dmitry.torokhov, robh, krzysztof.kozlowski+dt, conor+dt, jikos, linus.walleij, hsinyi, dri-devel, devicetree, linux-kernel, Benjamin Tissoires Hi, On Mon, Jul 15, 2024 at 7:22 AM Doug Anderson <dianders@google.com> wrote: > > Hi, > > On Mon, Jul 15, 2024 at 12:32 AM Zhaoxiong Lv > <lvzhaoxiong@huaqin.corp-partner.google.com> wrote: > > > > The Elan ekth6a12nay touch screen chip same as Elan eKTH6915 controller > > has a reset gpio. The difference is that they have different > > post_power_delay_ms. > > > > Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com> > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > FWIW things have changed enough between V1 and V2 that you probably > should have removed Conor's "Acked-by" tag here and waited for him to > re-add it. > > I'd also note that when posting a patch your Signed-off-by should > always be at the bottom of any collected tags. For reference [1]. > > [1] https://lore.kernel.org/tools/20221031165842.vxr4kp6h7qnkc53l@meerkat.local/ > > That being said, the new binding seems OK to me. > > Reviewed-by: Douglas Anderson <dianders@chromium.org> ...also, all of your patches seem to have the wrong address for Benjamin Tissoires. Can you fix that? I keep getting: Message not delivered Your message couldn't be delivered to benjamin.tissoires@redhat.co because the remote server is misconfigured. See technical details below for more information. ...because you have ".co" instead of ".com". Having the wrong email address for the maintainer is a good way for your patch not to get picked up. :-P I would further note that Benjamin seems to have moved from using his "redhat.com" address to his "kernel.org" address. See commit 139b4c37e9cb ("MAINTAINERS: update Benjamin's email address"). One last note is that get_maintainers should have suggested you email my @chromium.org address rather than my @google.com address. It's not a huge deal since they both come to the same place, but some maintainer tools will refuse to accept the "Reviewed-by" that I post with my @chromium.org address because my mail program will notice you sent to my @google.com address and send my reply from there. Probably you should be using a tool like "b4" or "patman" to help you send your patches out [1]. [1] https://youtu.be/7B3nKmBoFoQ -Doug ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2 2/2] HID: i2c-hid: elan: Add elan-ekth6a12nay timing 2024-07-15 7:31 [PATCH v2 0/2] HID: i2c-hid: elan: Add elan-ekth6a12nay timing Zhaoxiong Lv 2024-07-15 7:31 ` [PATCH v2 1/2] dt-bindings: HID: i2c-hid: elan: Introduce Elan ekth6a12nay Zhaoxiong Lv @ 2024-07-15 7:31 ` Zhaoxiong Lv 1 sibling, 0 replies; 7+ messages in thread From: Zhaoxiong Lv @ 2024-07-15 7:31 UTC (permalink / raw) To: dmitry.torokhov, robh, krzysztof.kozlowski+dt, conor+dt, jikos, benjamin.tissoires, linus.walleij, dianders, hsinyi Cc: dri-devel, devicetree, linux-kernel, Zhaoxiong Lv Elan-ekth6a12nay requires reset to pull down time greater than 10ms, so the configuration post_power_delay_ms is 10, and the chipset initial time is required to be greater than 300ms, so the post_gpio_reset_on_delay_ms is set to 300. Signed-off-by: Zhaoxiong Lv <lvzhaoxiong@huaqin.corp-partner.google.com> Reviewed-by: Douglas Anderson <dianders@chromium.org> --- Changes between V2 and V1: - 1. No changes. v1: https://lore.kernel.org/all/20240704085555.11204-3-lvzhaoxiong@huaqin.corp-partner.google.com/ --- drivers/hid/i2c-hid/i2c-hid-of-elan.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/hid/i2c-hid/i2c-hid-of-elan.c b/drivers/hid/i2c-hid/i2c-hid-of-elan.c index 091e37933225..3fcff6daa0d3 100644 --- a/drivers/hid/i2c-hid/i2c-hid-of-elan.c +++ b/drivers/hid/i2c-hid/i2c-hid-of-elan.c @@ -152,6 +152,13 @@ static const struct elan_i2c_hid_chip_data elan_ekth6915_chip_data = { .main_supply_name = "vcc33", }; +static const struct elan_i2c_hid_chip_data elan_ekth6a12nay_chip_data = { + .post_power_delay_ms = 10, + .post_gpio_reset_on_delay_ms = 300, + .hid_descriptor_address = 0x0001, + .main_supply_name = "vcc33", +}; + static const struct elan_i2c_hid_chip_data ilitek_ili9882t_chip_data = { .post_power_delay_ms = 1, .post_gpio_reset_on_delay_ms = 200, @@ -174,6 +181,7 @@ static const struct elan_i2c_hid_chip_data ilitek_ili2901_chip_data = { static const struct of_device_id elan_i2c_hid_of_match[] = { { .compatible = "elan,ekth6915", .data = &elan_ekth6915_chip_data }, + { .compatible = "elan,ekth6a12nay", .data = &elan_ekth6a12nay_chip_data }, { .compatible = "ilitek,ili9882t", .data = &ilitek_ili9882t_chip_data }, { .compatible = "ilitek,ili2901", .data = &ilitek_ili2901_chip_data }, { } -- 2.17.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-07-15 14:34 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2024-07-15 7:31 [PATCH v2 0/2] HID: i2c-hid: elan: Add elan-ekth6a12nay timing Zhaoxiong Lv 2024-07-15 7:31 ` [PATCH v2 1/2] dt-bindings: HID: i2c-hid: elan: Introduce Elan ekth6a12nay Zhaoxiong Lv 2024-07-15 14:22 ` Doug Anderson 2024-07-15 14:31 ` Conor Dooley 2024-07-15 14:34 ` Doug Anderson 2024-07-15 14:32 ` Doug Anderson 2024-07-15 7:31 ` [PATCH v2 2/2] HID: i2c-hid: elan: Add elan-ekth6a12nay timing Zhaoxiong Lv
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®