* [PATCH] crypto: arm64/poly1305 - move data to rodata section
@ 2024-07-15 7:20 Jia He
2024-08-02 13:15 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Jia He @ 2024-07-15 7:20 UTC (permalink / raw)
To: Herbert Xu, David S. Miller, Catalin Marinas, linux-crypto
Cc: Will Deacon, linux-arm-kernel, linux-kernel, Jia He
When objtool gains support for ARM in the future, it may encounter issues
disassembling the following data in the .text section:
> .Lzeros:
> .long 0,0,0,0,0,0,0,0
> .asciz "Poly1305 for ARMv8, CRYPTOGAMS by \@dot-asm"
> .align 2
Move it to .rodata which is a more appropriate section for read-only data.
Signed-off-by: Jia He <justin.he@arm.com>
---
Inspired by commit 1253cab8a352, although currently objtool hasn't been
supported on Arm, we should do some preparation(this patch) firstly.
arch/arm64/crypto/poly1305-armv8.pl | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/crypto/poly1305-armv8.pl b/arch/arm64/crypto/poly1305-armv8.pl
index cbc980fb02e3..bcb70c9541e9 100644
--- a/arch/arm64/crypto/poly1305-armv8.pl
+++ b/arch/arm64/crypto/poly1305-armv8.pl
@@ -885,10 +885,13 @@ poly1305_blocks_neon:
ret
.size poly1305_blocks_neon,.-poly1305_blocks_neon
+.pushsection .rodata
.align 5
.Lzeros:
.long 0,0,0,0,0,0,0,0
.asciz "Poly1305 for ARMv8, CRYPTOGAMS by \@dot-asm"
+.popsection
+
.align 2
#if !defined(__KERNEL__) && !defined(_WIN64)
.comm OPENSSL_armcap_P,4,4
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: arm64/poly1305 - move data to rodata section
2024-07-15 7:20 [PATCH] crypto: arm64/poly1305 - move data to rodata section Jia He
@ 2024-08-02 13:15 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2024-08-02 13:15 UTC (permalink / raw)
To: Jia He
Cc: David S. Miller, Catalin Marinas, linux-crypto, Will Deacon,
linux-arm-kernel, linux-kernel, Ard Biesheuvel
On Mon, Jul 15, 2024 at 07:20:23AM +0000, Jia He wrote:
> When objtool gains support for ARM in the future, it may encounter issues
> disassembling the following data in the .text section:
> > .Lzeros:
> > .long 0,0,0,0,0,0,0,0
> > .asciz "Poly1305 for ARMv8, CRYPTOGAMS by \@dot-asm"
> > .align 2
>
> Move it to .rodata which is a more appropriate section for read-only data.
>
> Signed-off-by: Jia He <justin.he@arm.com>
> ---
> Inspired by commit 1253cab8a352, although currently objtool hasn't been
> supported on Arm, we should do some preparation(this patch) firstly.
>
> arch/arm64/crypto/poly1305-armv8.pl | 3 +++
> 1 file changed, 3 insertions(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-02 13:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-15 7:20 [PATCH] crypto: arm64/poly1305 - move data to rodata section Jia He
2024-08-02 13:15 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®