From: Wei Yang <richard.weiyang@gmail.com>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH 1/2] radix tree test suite: include kconfig.h with incomplete path
Date: Tue, 16 Jul 2024 02:15:43 +0000 [thread overview]
Message-ID: <20240716021543.ghzeiq5yqtov43lk@master> (raw)
In-Reply-To: <20240712074151.27009-1-richard.weiyang@gmail.com>
On Fri, Jul 12, 2024 at 07:41:50AM +0000, Wei Yang wrote:
>The include path indicates it is the kconfig.h in tools/include/linux.
>
>Let's use the same format as others for better reading.
>
>Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
>CC: "Liam R. Howlett" <Liam.Howlett@oracle.com>
>CC: Matthew Wilcox (Oracle) <willy@infradead.org>
>---
> tools/testing/radix-tree/linux/kernel.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tools/testing/radix-tree/linux/kernel.h b/tools/testing/radix-tree/linux/kernel.h
>index c0a2bb785b92..fab6f47a9472 100644
>--- a/tools/testing/radix-tree/linux/kernel.h
>+++ b/tools/testing/radix-tree/linux/kernel.h
>@@ -11,7 +11,7 @@
> #include <linux/err.h>
> #include <linux/bitops.h>
> #include <linux/log2.h>
>-#include "../../../include/linux/kconfig.h"
>+#include <linux/kconfig.h>
Liam
I found the original code maybe not correct, but my change log here is not
exact either.
If my understanding is correct. In radix-tree test suite, we want to use the
kconfig.h in local linux/ directory.
But the original format "../../../include/linux/kconfig.h" is the one in
tools/.
My misunderstanding is <linux/kconfig.h> points to tools/. But since we
specify -I. before -I../../include, so it points to the local kconfig.h. This
is what we expect to use. By accident, the code change here seems correct.
If you think my understanding is correct, I would send a v2 with proper
changelog to describe it.
>
> #define printk printf
> #define pr_err printk
>--
>2.34.1
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2024-07-16 2:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 7:41 Wei Yang
2024-07-12 7:41 ` [PATCH 2/2] radix tree test suite: remove the local copy of kconfig.h Wei Yang
2024-07-15 16:17 ` [PATCH 1/2] radix tree test suite: include kconfig.h with incomplete path Liam R. Howlett
2024-07-16 0:58 ` Wei Yang
2024-07-16 2:15 ` Wei Yang [this message]
2024-07-16 2:31 ` Matthew Wilcox
2024-07-16 7:56 ` Wei Yang
2024-07-16 15:54 ` Liam R. Howlett
2024-07-17 0:34 ` Wei Yang
2024-07-29 1:53 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240716021543.ghzeiq5yqtov43lk@master \
--to=richard.weiyang@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®