mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wei Yang <richard.weiyang@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Wei Yang <richard.weiyang@gmail.com>,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>
Subject: Re: [PATCH 1/2] radix tree test suite: include kconfig.h with incomplete path
Date: Tue, 16 Jul 2024 07:56:09 +0000	[thread overview]
Message-ID: <20240716075609.rlw523szys2jztpy@master> (raw)
In-Reply-To: <ZpXbalVnI9FzHMHx@casper.infradead.org>

On Tue, Jul 16, 2024 at 03:31:06AM +0100, Matthew Wilcox wrote:
>On Tue, Jul 16, 2024 at 02:15:43AM +0000, Wei Yang wrote:
>> If you think my understanding is correct, I would send a v2 with proper
>> changelog to describe it.
>
>It seems like you're trying to change something that isn't broken.

Currently we don't find the problem because these two kconfig.h is similar.
The only difference is the one in tools/ doesn't include "generated/autoconf.h".

And in related files, like include/linux/xarray.h, includes the correct
kconfig.h.

It is not broken, but doesn't mean it is correct, IMO.

-- 
Wei Yang
Help you, Help me

  reply	other threads:[~2024-07-16  7:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-12  7:41 Wei Yang
2024-07-12  7:41 ` [PATCH 2/2] radix tree test suite: remove the local copy of kconfig.h Wei Yang
2024-07-15 16:17 ` [PATCH 1/2] radix tree test suite: include kconfig.h with incomplete path Liam R. Howlett
2024-07-16  0:58   ` Wei Yang
2024-07-16  2:15 ` Wei Yang
2024-07-16  2:31   ` Matthew Wilcox
2024-07-16  7:56     ` Wei Yang [this message]
2024-07-16 15:54       ` Liam R. Howlett
2024-07-17  0:34         ` Wei Yang
2024-07-29  1:53           ` Wei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240716075609.rlw523szys2jztpy@master \
    --to=richard.weiyang@gmail.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®