From: Ping Gan <jacky_gam_2001@163.com>
To: hare@suse.de, sagi@grimberg.me, hch@lst.de, kch@nvidia.com,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: ping.gan@dell.com, Ping Gan <jacky_gam_2001@163.com>
Subject: [PATCH v2 2/2] nvmet-rdma: add unbound_wq support for nvmet-rdma
Date: Wed, 17 Jul 2024 17:14:51 +0800 [thread overview]
Message-ID: <20240717091451.111158-3-jacky_gam_2001@163.com> (raw)
In-Reply-To: <20240717091451.111158-1-jacky_gam_2001@163.com>
To define a module parameter use_unbound_wq to enable unbound
workqueue to handle RDMA's IO of CQ.
Signed-off-by: Ping Gan <jacky_gam_2001@163.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
---
drivers/nvme/target/rdma.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
index 1eff8ca6a5f1..bfd7106316bc 100644
--- a/drivers/nvme/target/rdma.c
+++ b/drivers/nvme/target/rdma.c
@@ -155,6 +155,10 @@ static int nvmet_rdma_srq_size = 1024;
module_param_cb(srq_size, &srq_size_ops, &nvmet_rdma_srq_size, 0644);
MODULE_PARM_DESC(srq_size, "set Shared Receive Queue (SRQ) size, should >= 256 (default: 1024)");
+static bool use_unbound_wq;
+module_param(use_unbound_wq, bool, 0444);
+MODULE_PARM_DESC(use_unbound_wq, "use unbound workqueue to handle IO request: Default false");
+
static DEFINE_IDA(nvmet_rdma_queue_ida);
static LIST_HEAD(nvmet_rdma_queue_list);
static DEFINE_MUTEX(nvmet_rdma_queue_mutex);
@@ -1259,7 +1263,11 @@ static int nvmet_rdma_create_queue_ib(struct nvmet_rdma_queue *queue)
*/
nr_cqe = queue->recv_queue_size + 2 * queue->send_queue_size;
- queue->cq = ib_cq_pool_get(ndev->device, nr_cqe + 1,
+ if (use_unbound_wq)
+ queue->cq = ib_cq_pool_get(ndev->device, nr_cqe + 1,
+ queue->comp_vector, IB_POLL_UNBOUND_WORKQUEUE);
+ else
+ queue->cq = ib_cq_pool_get(ndev->device, nr_cqe + 1,
queue->comp_vector, IB_POLL_WORKQUEUE);
if (IS_ERR(queue->cq)) {
ret = PTR_ERR(queue->cq);
--
2.26.2
next prev parent reply other threads:[~2024-07-17 9:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 9:14 [PATCH v2 0/2] nvmet: support unbound_wq for RDMA and TCP Ping Gan
2024-07-17 9:14 ` [PATCH v2 1/2] nvmet-tcp: add unbound_wq support for nvmet-tcp Ping Gan
2024-07-17 20:28 ` Sagi Grimberg
2024-07-17 9:14 ` Ping Gan [this message]
2024-07-17 20:29 ` [PATCH v2 2/2] nvmet-rdma: add unbound_wq support for nvmet-rdma Sagi Grimberg
2024-07-19 5:31 ` [PATCH v2 0/2] nvmet: support unbound_wq for RDMA and TCP Christoph Hellwig
2024-07-19 6:28 ` Hannes Reinecke
2024-07-19 8:07 ` Ping Gan
2024-07-19 8:26 ` Hannes Reinecke
2024-07-19 8:49 ` Ping Gan
2024-07-21 11:11 ` Sagi Grimberg
2024-07-21 11:09 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240717091451.111158-3-jacky_gam_2001@163.com \
--to=jacky_gam_2001@163.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ping.gan@dell.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®