mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: 47 Mohit Pawar <mohitpawar@mitaoe.ac.in>
Cc: brauner@kernel.org, jack@suse.cz, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] Fixed: fs: file_table_c: Missing blank line warnings
Date: Mon, 22 Jul 2024 18:37:41 +0200	[thread overview]
Message-ID: <20240722163741.us3r3v5pe2d76azk@quack3> (raw)
In-Reply-To: <CAO-FDEOhDSxOw8jyxtdqhJP8-wz8QP+Veo0yGehXTM9F=4bsnA@mail.gmail.com>

On Mon 15-07-24 09:26:29, 47 Mohit Pawar wrote:
> From: Mohit0404 <mohitpawar@mitaoe.ac.in>
> 
> Fixed-
>         WARNING: Missing a blank line after declarations
>         WARNING: Missing a blank line after declarations

The patch is missing your Signed-off-by tag. Please add it. Also I'm not
sure how Christian sees these pure whitespace cleanups but in this case it
is probably at least a readability win so feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/file_table.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/file_table.c b/fs/file_table.c
> index 4f03beed4737..9950293535e4 100644
> --- a/fs/file_table.c
> +++ b/fs/file_table.c
> @@ -136,6 +136,7 @@ static int __init init_fs_stat_sysctls(void)
>         register_sysctl_init("fs", fs_stat_sysctls);
>         if (IS_ENABLED(CONFIG_BINFMT_MISC)) {
>                 struct ctl_table_header *hdr;
> +
>                 hdr = register_sysctl_mount_point("fs/binfmt_misc");
>                 kmemleak_not_leak(hdr);
>         }
> @@ -384,6 +385,7 @@ struct file *alloc_file_clone(struct file *base, int
> flags,
>                                 const struct file_operations *fops)
>  {
>         struct file *f = alloc_file(&base->f_path, flags, fops);
> +
>         if (!IS_ERR(f)) {
>                 path_get(&f->f_path);
>                 f->f_mapping = base->f_mapping;
> 
> --
> 2.34.1
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

  parent reply	other threads:[~2024-07-22 16:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-13 18:06 mohitpawar
     [not found] ` <CAO-FDEOhDSxOw8jyxtdqhJP8-wz8QP+Veo0yGehXTM9F=4bsnA@mail.gmail.com>
2024-07-22 16:37   ` Jan Kara [this message]
2024-07-23  7:47     ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240722163741.us3r3v5pe2d76azk@quack3 \
    --to=jack@suse.cz \
    --cc=brauner@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mohitpawar@mitaoe.ac.in \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®