* [PATCH 3/3] Fixed: fs: file_table_c: Missing blank line warnings
@ 2024-07-13 18:06 mohitpawar
[not found] ` <CAO-FDEOhDSxOw8jyxtdqhJP8-wz8QP+Veo0yGehXTM9F=4bsnA@mail.gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: mohitpawar @ 2024-07-13 18:06 UTC (permalink / raw)
To: viro; +Cc: brauner, jack, linux-fsdevel, linux-kernel, Mohit0404
From: Mohit0404 <mohitpawar@mitaoe.ac.in>
Fixed-
WARNING: Missing a blank line after declarations
WARNING: Missing a blank line after declarations
---
fs/file_table.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/file_table.c b/fs/file_table.c
index 4f03beed4737..9950293535e4 100644
--- a/fs/file_table.c
+++ b/fs/file_table.c
@@ -136,6 +136,7 @@ static int __init init_fs_stat_sysctls(void)
register_sysctl_init("fs", fs_stat_sysctls);
if (IS_ENABLED(CONFIG_BINFMT_MISC)) {
struct ctl_table_header *hdr;
+
hdr = register_sysctl_mount_point("fs/binfmt_misc");
kmemleak_not_leak(hdr);
}
@@ -384,6 +385,7 @@ struct file *alloc_file_clone(struct file *base, int flags,
const struct file_operations *fops)
{
struct file *f = alloc_file(&base->f_path, flags, fops);
+
if (!IS_ERR(f)) {
path_get(&f->f_path);
f->f_mapping = base->f_mapping;
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 3/3] Fixed: fs: file_table_c: Missing blank line warnings
[not found] ` <CAO-FDEOhDSxOw8jyxtdqhJP8-wz8QP+Veo0yGehXTM9F=4bsnA@mail.gmail.com>
@ 2024-07-22 16:37 ` Jan Kara
2024-07-23 7:47 ` Christian Brauner
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kara @ 2024-07-22 16:37 UTC (permalink / raw)
To: 47 Mohit Pawar; +Cc: brauner, jack, linux-fsdevel, linux-kernel
On Mon 15-07-24 09:26:29, 47 Mohit Pawar wrote:
> From: Mohit0404 <mohitpawar@mitaoe.ac.in>
>
> Fixed-
> WARNING: Missing a blank line after declarations
> WARNING: Missing a blank line after declarations
The patch is missing your Signed-off-by tag. Please add it. Also I'm not
sure how Christian sees these pure whitespace cleanups but in this case it
is probably at least a readability win so feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/file_table.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/file_table.c b/fs/file_table.c
> index 4f03beed4737..9950293535e4 100644
> --- a/fs/file_table.c
> +++ b/fs/file_table.c
> @@ -136,6 +136,7 @@ static int __init init_fs_stat_sysctls(void)
> register_sysctl_init("fs", fs_stat_sysctls);
> if (IS_ENABLED(CONFIG_BINFMT_MISC)) {
> struct ctl_table_header *hdr;
> +
> hdr = register_sysctl_mount_point("fs/binfmt_misc");
> kmemleak_not_leak(hdr);
> }
> @@ -384,6 +385,7 @@ struct file *alloc_file_clone(struct file *base, int
> flags,
> const struct file_operations *fops)
> {
> struct file *f = alloc_file(&base->f_path, flags, fops);
> +
> if (!IS_ERR(f)) {
> path_get(&f->f_path);
> f->f_mapping = base->f_mapping;
>
> --
> 2.34.1
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 3/3] Fixed: fs: file_table_c: Missing blank line warnings
2024-07-22 16:37 ` Jan Kara
@ 2024-07-23 7:47 ` Christian Brauner
0 siblings, 0 replies; 3+ messages in thread
From: Christian Brauner @ 2024-07-23 7:47 UTC (permalink / raw)
To: Jan Kara; +Cc: 47 Mohit Pawar, linux-fsdevel, linux-kernel
On Mon, Jul 22, 2024 at 06:37:41PM GMT, Jan Kara wrote:
> On Mon 15-07-24 09:26:29, 47 Mohit Pawar wrote:
> > From: Mohit0404 <mohitpawar@mitaoe.ac.in>
> >
> > Fixed-
> > WARNING: Missing a blank line after declarations
> > WARNING: Missing a blank line after declarations
>
> The patch is missing your Signed-off-by tag. Please add it. Also I'm not
> sure how Christian sees these pure whitespace cleanups but in this case it
I'm personally pro such cleanups.
> is probably at least a readability win so feel free to add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
>
> Honza
>
> > ---
> > fs/file_table.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/fs/file_table.c b/fs/file_table.c
> > index 4f03beed4737..9950293535e4 100644
> > --- a/fs/file_table.c
> > +++ b/fs/file_table.c
> > @@ -136,6 +136,7 @@ static int __init init_fs_stat_sysctls(void)
> > register_sysctl_init("fs", fs_stat_sysctls);
> > if (IS_ENABLED(CONFIG_BINFMT_MISC)) {
> > struct ctl_table_header *hdr;
> > +
> > hdr = register_sysctl_mount_point("fs/binfmt_misc");
> > kmemleak_not_leak(hdr);
> > }
> > @@ -384,6 +385,7 @@ struct file *alloc_file_clone(struct file *base, int
> > flags,
> > const struct file_operations *fops)
> > {
> > struct file *f = alloc_file(&base->f_path, flags, fops);
> > +
> > if (!IS_ERR(f)) {
I would then change that to:
struct file *f;
f = alloc_file(&base->f_path, flags, fops);
if (!IS_ERR(f)) {
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-23 7:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-13 18:06 [PATCH 3/3] Fixed: fs: file_table_c: Missing blank line warnings mohitpawar
[not found] ` <CAO-FDEOhDSxOw8jyxtdqhJP8-wz8QP+Veo0yGehXTM9F=4bsnA@mail.gmail.com>
2024-07-22 16:37 ` Jan Kara
2024-07-23 7:47 ` Christian Brauner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®