[PATCH] fs/writeback: fix kernel-doc warnings

[PATCH] fs/writeback: fix kernel-doc warnings

[Haifeng Xu]

The kernel test robot reported kernel-doc warnings here:

    fs/fs-writeback.c:1144: warning: Function parameter or struct member 'sb' not described in 'cgroup_writeback_umount'

cgroup_writeback_umount() is missing an argument description, fix it.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202407261749.LkRbgZxK-lkp@intel.com/
Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
---
 fs/fs-writeback.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index 09facd4356d9..cf08f622d720 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -1132,6 +1132,7 @@ int cgroup_writeback_by_id(u64 bdi_id, int memcg_id,
 
 /**
  * cgroup_writeback_umount - flush inode wb switches for umount
+ * @sb: superblock to kill
  *
  * This function is called when a super_block is about to be destroyed and
  * flushes in-flight inode wb switches.  An inode wb switch goes through
-- 
2.25.1

Re: [PATCH] fs/writeback: fix kernel-doc warnings

[Christian Brauner]

On Mon, Jul 29, 2024 at 10:06:06AM GMT, Haifeng Xu wrote:
> The kernel test robot reported kernel-doc warnings here:
> 
>     fs/fs-writeback.c:1144: warning: Function parameter or struct member 'sb' not described in 'cgroup_writeback_umount'
> 
> cgroup_writeback_umount() is missing an argument description, fix it.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202407261749.LkRbgZxK-lkp@intel.com/
> Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
> ---

Unfortunately I had already fixed that before applying. Thanks though!

Re: [PATCH] fs/writeback: fix kernel-doc warnings

[Haifeng Xu]

On 2024/7/29 17:12, Christian Brauner wrote:
> On Mon, Jul 29, 2024 at 10:06:06AM GMT, Haifeng Xu wrote:
>> The kernel test robot reported kernel-doc warnings here:
>>
>>     fs/fs-writeback.c:1144: warning: Function parameter or struct member 'sb' not described in 'cgroup_writeback_umount'
>>
>> cgroup_writeback_umount() is missing an argument description, fix it.
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes: https://urldefense.proofpoint.com/v2/url?u=https-3A__lore.kernel.org_oe-2Dkbuild-2Dall_202407261749.LkRbgZxK-2Dlkp-40intel.com_&d=DwIBaQ&c=R1GFtfTqKXCFH-lgEPXWwic6stQkW4U7uVq33mt-crw&r=3uoFsejk1jN2oga47MZfph01lLGODc93n4Zqe7b0NRk&m=3sAi8IhB62KzbeV_8pr_6us5hrO-Gga06if2AaD4IQo4VIdWPC-0PKIGoZBqxcE1&s=8yhRcJ4dpQqgNctjFIIXg2P-2gJxFL66FZoYu5O90ho&e= 
>> Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
>> ---
> 
> Unfortunately I had already fixed that before applying. Thanks though!

OK, Thanks!