mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sangmoon Kim <sangmoon.kim@samsung.com>
To: Tejun Heo <tj@kernel.org>
Cc: youngjae24.lim@samsung.com, jordan.lim@samsung.com,
	myoungjae.kim@samsung.com,
	Sangmoon Kim <sangmoon.kim@samsung.com>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] workqueue: add cmdline parameter workqueue.panic_on_watchdog/max_watchdog_to_panic
Date: Tue, 30 Jul 2024 17:04:28 +0900	[thread overview]
Message-ID: <20240730080428.2556769-1-sangmoon.kim@samsung.com> (raw)
In-Reply-To: <CGME20240730080541epcas1p144c86d09c0141102bfd89e58759b9140@epcas1p1.samsung.com>

When we want to debug the workqueue stall, we can immediately make
a panic to get the information we want.

In some systems, it may be necessary to quickly reboot the system to
escape from a workqueue lockup situation. In this case, we can control
the number of stall detections to generate panic.

Signed-off-by: Sangmoon Kim <sangmoon.kim@samsung.com>
---
 kernel/workqueue.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index dfd42c28e404..893310ce23be 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -7406,6 +7406,11 @@ static struct timer_list wq_watchdog_timer;
 static unsigned long wq_watchdog_touched = INITIAL_JIFFIES;
 static DEFINE_PER_CPU(unsigned long, wq_watchdog_touched_cpu) = INITIAL_JIFFIES;
 
+static bool wq_panic_on_watchdog;
+module_param_named(panic_on_watchdog, wq_panic_on_watchdog, bool, 0644);
+static unsigned int wq_max_watchdog_to_panic;
+module_param_named(max_watchdog_to_panic, wq_max_watchdog_to_panic, uint, 0644);
+
 /*
  * Show workers that might prevent the processing of pending work items.
  * The only candidates are CPU-bound workers in the running state.
@@ -7457,6 +7462,16 @@ static void show_cpu_pools_hogs(void)
 	rcu_read_unlock();
 }
 
+static void panic_on_wq_watchdog(void)
+{
+	static unsigned int wq_busy;
+
+	if (wq_panic_on_watchdog) {
+		wq_busy++;
+		BUG_ON(wq_busy >= wq_max_watchdog_to_panic);
+	}
+}
+
 static void wq_watchdog_reset_touched(void)
 {
 	int cpu;
@@ -7529,6 +7544,9 @@ static void wq_watchdog_timer_fn(struct timer_list *unused)
 	if (cpu_pool_stall)
 		show_cpu_pools_hogs();
 
+	if (lockup_detected)
+		panic_on_wq_watchdog();
+
 	wq_watchdog_reset_touched();
 	mod_timer(&wq_watchdog_timer, jiffies + thresh);
 }
-- 
2.34.1


       reply	other threads:[~2024-07-30  8:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240730080541epcas1p144c86d09c0141102bfd89e58759b9140@epcas1p1.samsung.com>
2024-07-30  8:04 ` Sangmoon Kim [this message]
2024-07-30 21:43   ` Tejun Heo
     [not found]     ` <CGME20240805023154epcas1p47037b2487d0d2c3623b96eba0d87d714@epcas1p4.samsung.com>
2024-08-05  2:31       ` Sangmoon Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240730080428.2556769-1-sangmoon.kim@samsung.com \
    --to=sangmoon.kim@samsung.com \
    --cc=jiangshanlai@gmail.com \
    --cc=jordan.lim@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myoungjae.kim@samsung.com \
    --cc=tj@kernel.org \
    --cc=youngjae24.lim@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®