mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Sangmoon Kim <sangmoon.kim@samsung.com>
Cc: youngjae24.lim@samsung.com, jordan.lim@samsung.com,
	myoungjae.kim@samsung.com, Lai Jiangshan <jiangshanlai@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] workqueue: add cmdline parameter workqueue.panic_on_watchdog/max_watchdog_to_panic
Date: Tue, 30 Jul 2024 11:43:53 -1000	[thread overview]
Message-ID: <ZqlemexVxV0LQVGR@slm.duckdns.org> (raw)
In-Reply-To: <20240730080428.2556769-1-sangmoon.kim@samsung.com>

Hello,

On Tue, Jul 30, 2024 at 05:04:28PM +0900, Sangmoon Kim wrote:
> +static bool wq_panic_on_watchdog;
> +module_param_named(panic_on_watchdog, wq_panic_on_watchdog, bool, 0644);
> +static unsigned int wq_max_watchdog_to_panic;
> +module_param_named(max_watchdog_to_panic, wq_max_watchdog_to_panic, uint, 0644);

Can you combine the two into a single parameter? Maybe name it
wq_panic_on_stall? 0 disables. >0 indicates the number of times before
triggering panic, maybe?

Thanks.

-- 
tejun

  reply	other threads:[~2024-07-30 21:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240730080541epcas1p144c86d09c0141102bfd89e58759b9140@epcas1p1.samsung.com>
2024-07-30  8:04 ` Sangmoon Kim
2024-07-30 21:43   ` Tejun Heo [this message]
     [not found]     ` <CGME20240805023154epcas1p47037b2487d0d2c3623b96eba0d87d714@epcas1p4.samsung.com>
2024-08-05  2:31       ` Sangmoon Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZqlemexVxV0LQVGR@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=jiangshanlai@gmail.com \
    --cc=jordan.lim@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myoungjae.kim@samsung.com \
    --cc=sangmoon.kim@samsung.com \
    --cc=youngjae24.lim@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®