From: Aleksa Sarai <cyphar@cyphar.com>
To: Ian Kent <raven@themaw.net>, Bill O'Donnell <bodonnel@redhat.com>,
Christian Brauner <brauner@kernel.org>,
Jan Harkes <jaharkes@cs.cmu.edu>,
coda@cs.cmu.edu, Eric Sandeen <sandeen@redhat.com>,
David Howells <dhowells@redhat.com>
Cc: autofs@vger.kernel.org, linux-kernel@vger.kernel.org,
codalist@coda.cs.cmu.edu, Aleksa Sarai <cyphar@cyphar.com>
Subject: [PATCH v2 0/2] fsconfig: minor fsparam_fd fixes
Date: Wed, 31 Jul 2024 23:10:26 +1000 [thread overview]
Message-ID: <20240731-fsconfig-fsparam_fd-fixes-v2-0-e7c472224417@cyphar.com> (raw)
While working on adding an fsparam_fd() argument to cgroupfs, I noticed
that there are only two users of fsparam_fd() and they both seemed to
have minor issues:
* autofs has a missing fput() when using FSCONFIG_SET_FD.
* coda uses fsparam_fd() but it ignores param->file and so ends up
re-getting the file. This doesn't change the behaviour but it seems
preferable to have all users of fsparam_fd() have the same logic.
I have tested this logic for the cgroupfs patch but I have only compile
tested the fixes for autofs and coda.
The second patch is not really required, so feel free to drop it if you
feel the original version was cleaner.
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
---
Changes in v2:
- Fix fs/coda/inode.c build errors.
- Link to v1: https://lore.kernel.org/r/20240719-fsconfig-fsparam_fd-fixes-v1-0-7ccd315c2ad4@cyphar.com
---
Aleksa Sarai (2):
autofs: fix missing fput for FSCONFIG_SET_FD
coda: use param->file for FSCONFIG_SET_FD
fs/autofs/inode.c | 3 +--
fs/coda/inode.c | 43 ++++++++++++++++++++++++++++++-------------
2 files changed, 31 insertions(+), 15 deletions(-)
---
base-commit: c7b9563b58a77423d4c6e026ff831a69612b02fc
change-id: 20240714-fsconfig-fsparam_fd-fixes-09f2e741c28d
Best regards,
--
Aleksa Sarai <cyphar@cyphar.com>
next reply other threads:[~2024-07-31 13:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 13:10 Aleksa Sarai [this message]
2024-07-31 13:10 ` [PATCH v2 1/2] autofs: fix missing fput for FSCONFIG_SET_FD Aleksa Sarai
2024-07-31 13:10 ` [PATCH v2 2/2] coda: use param->file " Aleksa Sarai
2024-08-01 7:04 ` [PATCH v2 0/2] fsconfig: minor fsparam_fd fixes Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240731-fsconfig-fsparam_fd-fixes-v2-0-e7c472224417@cyphar.com \
--to=cyphar@cyphar.com \
--cc=autofs@vger.kernel.org \
--cc=bodonnel@redhat.com \
--cc=brauner@kernel.org \
--cc=coda@cs.cmu.edu \
--cc=codalist@coda.cs.cmu.edu \
--cc=dhowells@redhat.com \
--cc=jaharkes@cs.cmu.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®