From: Christian Brauner <brauner@kernel.org>
To: Aleksa Sarai <cyphar@cyphar.com>
Cc: Christian Brauner <brauner@kernel.org>,
autofs@vger.kernel.org, linux-kernel@vger.kernel.org,
codalist@coda.cs.cmu.edu, Ian Kent <raven@themaw.net>,
Bill O'Donnell <bodonnel@redhat.com>,
Jan Harkes <jaharkes@cs.cmu.edu>,
coda@cs.cmu.edu, Eric Sandeen <sandeen@redhat.com>,
David Howells <dhowells@redhat.com>
Subject: Re: [PATCH v2 0/2] fsconfig: minor fsparam_fd fixes
Date: Thu, 1 Aug 2024 09:04:54 +0200 [thread overview]
Message-ID: <20240801-manchmal-produkt-16d3e590cfb1@brauner> (raw)
In-Reply-To: <20240731-fsconfig-fsparam_fd-fixes-v2-0-e7c472224417@cyphar.com>
On Wed, 31 Jul 2024 23:10:26 +1000, Aleksa Sarai wrote:
> While working on adding an fsparam_fd() argument to cgroupfs, I noticed
> that there are only two users of fsparam_fd() and they both seemed to
> have minor issues:
>
> * autofs has a missing fput() when using FSCONFIG_SET_FD.
> * coda uses fsparam_fd() but it ignores param->file and so ends up
> re-getting the file. This doesn't change the behaviour but it seems
> preferable to have all users of fsparam_fd() have the same logic.
>
> [...]
Applied to the vfs.misc branch of the vfs/vfs.git tree.
Patches in the vfs.misc branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.misc
[1/2] autofs: fix missing fput for FSCONFIG_SET_FD
https://git.kernel.org/vfs/vfs/c/9f6b314ecc8b
[2/2] coda: use param->file for FSCONFIG_SET_FD
https://git.kernel.org/vfs/vfs/c/b0839e9bbc5b
prev parent reply other threads:[~2024-08-01 7:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 13:10 Aleksa Sarai
2024-07-31 13:10 ` [PATCH v2 1/2] autofs: fix missing fput for FSCONFIG_SET_FD Aleksa Sarai
2024-07-31 13:10 ` [PATCH v2 2/2] coda: use param->file " Aleksa Sarai
2024-08-01 7:04 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240801-manchmal-produkt-16d3e590cfb1@brauner \
--to=brauner@kernel.org \
--cc=autofs@vger.kernel.org \
--cc=bodonnel@redhat.com \
--cc=coda@cs.cmu.edu \
--cc=codalist@coda.cs.cmu.edu \
--cc=cyphar@cyphar.com \
--cc=dhowells@redhat.com \
--cc=jaharkes@cs.cmu.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®