From: Andrew Morton <akpm@linux-foundation.org>
To: Carlos Llamas <cmllamas@google.com>
Cc: linux-kernel@vger.kernel.org, kernel-team@android.com,
"J. R. Okajima" <hooanon05g@gmail.com>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v2] lockdep: upper limit LOCKDEP_CHAINS_BITS
Date: Wed, 31 Jul 2024 16:48:23 -0700 [thread overview]
Message-ID: <20240731164823.c8ac96ab0f8968ce8213c02d@linux-foundation.org> (raw)
In-Reply-To: <20240723164018.2489615-1-cmllamas@google.com>
On Tue, 23 Jul 2024 16:40:17 +0000 Carlos Llamas <cmllamas@google.com> wrote:
> From: "J. R. Okajima" <hooanon05g@gmail.com>
>
> CONFIG_LOCKDEP_CHAINS_BITS value decides the size of chain_hlocks[] in
> kernel/locking/lockdep.c, and it is checked by add_chain_cache() with
> BUILD_BUG_ON((1UL << 24) <= ARRAY_SIZE(chain_hlocks));
> This patch is just to silence BUILD_BUG_ON().
>
> ...
>
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1515,7 +1515,7 @@ config LOCKDEP_BITS
> config LOCKDEP_CHAINS_BITS
> int "Bitsize for MAX_LOCKDEP_CHAINS"
> depends on LOCKDEP && !LOCKDEP_SMALL
> - range 10 30
> + range 10 21
> default 16
> help
> Try increasing this value if you hit "BUG: MAX_LOCKDEP_CHAINS too low!" message.
checking your homework...
With LOCKDEP_CHAINS_BITS == 21:
#define MAX_LOCKDEP_CHAINS_BITS CONFIG_LOCKDEP_CHAINS_BITS
gives MAX_LOCKDEP_CHAINS_BITS == 21
#define MAX_LOCKDEP_CHAINS (1UL << MAX_LOCKDEP_CHAINS_BITS)
gives MAX_LOCKDEP_CHAINS == (1UL << 21)
#define MAX_LOCKDEP_CHAIN_HLOCKS (MAX_LOCKDEP_CHAINS*5)
gives MAX_LOCKDEP_CHAIN_HLOCKS = 5 * (1UL << 21)
static u16 chain_hlocks[MAX_LOCKDEP_CHAIN_HLOCKS];
gives ARRAY_SIZE(chain_hlocks) == 5 * (1UL << 21)
so
BUILD_BUG_ON((1UL << 24) <= ARRAY_SIZE(chain_hlocks));
ie, BUILD_BUG_ON((1UL << 24) <= 5 * (1UL << 21));
is OK, whereas
BUILD_BUG_ON((1UL << 24) <= 5 * (1UL << 22));
will bug out. So LGTM, I'll add it to mm.git.
btw, the help text "Bitsize for MAX_LOCKDEP_CHAINS" is odd. What's a
bitsize? Maybe "bit shift count for..." or such.
next prev parent reply other threads:[~2024-07-31 23:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 13:39 LOCKDEP customizable numbers upper limit J. R. Okajima
2021-05-13 14:27 ` Tetsuo Handa
2021-05-14 18:22 ` PATCH: " hooanon05g
2021-05-14 22:41 ` Tetsuo Handa
2024-07-23 16:40 ` [PATCH v2] lockdep: upper limit LOCKDEP_CHAINS_BITS Carlos Llamas
2024-07-31 23:48 ` Andrew Morton [this message]
2024-08-01 16:25 ` Carlos Llamas
2024-08-01 23:51 ` J. R. Okajima
2024-08-05 19:58 ` Carlos Llamas
2024-08-06 1:05 ` Carlos Llamas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240731164823.c8ac96ab0f8968ce8213c02d@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cmllamas@google.com \
--cc=hooanon05g@gmail.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®