From: Carlos Llamas <cmllamas@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, kernel-team@android.com,
"J. R. Okajima" <hooanon05g@gmail.com>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v2] lockdep: upper limit LOCKDEP_CHAINS_BITS
Date: Mon, 5 Aug 2024 19:58:07 +0000 [thread overview]
Message-ID: <ZrEuz9bjZcBq6jNG@google.com> (raw)
In-Reply-To: <20240731164823.c8ac96ab0f8968ce8213c02d@linux-foundation.org>
On Wed, Jul 31, 2024 at 04:48:23PM -0700, Andrew Morton wrote:
> btw, the help text "Bitsize for MAX_LOCKDEP_CHAINS" is odd. What's a
> bitsize? Maybe "bit shift count for..." or such.
Yeah, maybe a _SHIFT suffix would have been better fit for these configs
instead of _BITS. Similar to PAGE_SHIFT or NODES_SHIFT. Anyways, I can
send a patch to improve the help text. How about something like:
"Size for ... (as a power of 2)"
I'll also send a separate patch to fix the rest of the upper limits. Any
of the (1 << 30) shifts allocates static arrays that blow past the .bss
segment. Just as originally reporeted by J. R. Okajima.
--
Carlos Llamas
next prev parent reply other threads:[~2024-08-05 19:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 13:39 LOCKDEP customizable numbers upper limit J. R. Okajima
2021-05-13 14:27 ` Tetsuo Handa
2021-05-14 18:22 ` PATCH: " hooanon05g
2021-05-14 22:41 ` Tetsuo Handa
2024-07-23 16:40 ` [PATCH v2] lockdep: upper limit LOCKDEP_CHAINS_BITS Carlos Llamas
2024-07-31 23:48 ` Andrew Morton
2024-08-01 16:25 ` Carlos Llamas
2024-08-01 23:51 ` J. R. Okajima
2024-08-05 19:58 ` Carlos Llamas [this message]
2024-08-06 1:05 ` Carlos Llamas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrEuz9bjZcBq6jNG@google.com \
--to=cmllamas@google.com \
--cc=akpm@linux-foundation.org \
--cc=hooanon05g@gmail.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome