* [PATCH 1/1] ASoC: mediatek: mt8188: add register to volatile_register
@ 2024-08-01 3:10 yr.yang
2024-08-01 4:01 ` Chen-Yu Tsai
0 siblings, 1 reply; 2+ messages in thread
From: yr.yang @ 2024-08-01 3:10 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Matthias Brugger, AngeloGioacchino Del Regno
Cc: linux-sound, linux-kernel, linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group, YR Yang
From: YR Yang <yr.yang@mediatek.com>
Add AFE Control Register 0 to volatile_register.
AFE_DAC_CON0 can be modified by both SOF and ALSA driver.
If this register read & write by cache mode,
the cached value may be not the real value
when the register modified by other side.
It will cause playback or capture fail.
Need add AFE_DAC_CON0 to volatile register.
Signed-off-by: YR Yang <yr.yang@mediatek.com>
---
sound/soc/mediatek/mt8188/mt8188-afe-pcm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/mediatek/mt8188/mt8188-afe-pcm.c b/sound/soc/mediatek/mt8188/mt8188-afe-pcm.c
index ccb6c1f3adc7..73e5c63aeec8 100644
--- a/sound/soc/mediatek/mt8188/mt8188-afe-pcm.c
+++ b/sound/soc/mediatek/mt8188/mt8188-afe-pcm.c
@@ -2748,6 +2748,7 @@ static bool mt8188_is_volatile_reg(struct device *dev, unsigned int reg)
case AFE_ASRC12_NEW_CON9:
case AFE_LRCK_CNT:
case AFE_DAC_MON0:
+ case AFE_DAC_CON0:
case AFE_DL2_CUR:
case AFE_DL3_CUR:
case AFE_DL6_CUR:
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] ASoC: mediatek: mt8188: add register to volatile_register
2024-08-01 3:10 [PATCH 1/1] ASoC: mediatek: mt8188: add register to volatile_register yr.yang
@ 2024-08-01 4:01 ` Chen-Yu Tsai
0 siblings, 0 replies; 2+ messages in thread
From: Chen-Yu Tsai @ 2024-08-01 4:01 UTC (permalink / raw)
To: yr.yang
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Matthias Brugger, AngeloGioacchino Del Regno, linux-sound,
linux-kernel, linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group
Hi,
On Thu, Aug 1, 2024 at 11:11 AM yr.yang <yr.yang@mediatek.com> wrote:
>
> From: YR Yang <yr.yang@mediatek.com>
>
> Add AFE Control Register 0 to volatile_register.
> AFE_DAC_CON0 can be modified by both SOF and ALSA driver.
> If this register read & write by cache mode,
> the cached value may be not the real value
> when the register modified by other side.
> It will cause playback or capture fail.
> Need add AFE_DAC_CON0 to volatile register.
You should mention this specific register in the patch subject.
Something like:
ASoC: mediatek: mt8188: Mark AFE_DAC_CON0 register as volatile
ChenYu
> Signed-off-by: YR Yang <yr.yang@mediatek.com>
>
> ---
> sound/soc/mediatek/mt8188/mt8188-afe-pcm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/mediatek/mt8188/mt8188-afe-pcm.c b/sound/soc/mediatek/mt8188/mt8188-afe-pcm.c
> index ccb6c1f3adc7..73e5c63aeec8 100644
> --- a/sound/soc/mediatek/mt8188/mt8188-afe-pcm.c
> +++ b/sound/soc/mediatek/mt8188/mt8188-afe-pcm.c
> @@ -2748,6 +2748,7 @@ static bool mt8188_is_volatile_reg(struct device *dev, unsigned int reg)
> case AFE_ASRC12_NEW_CON9:
> case AFE_LRCK_CNT:
> case AFE_DAC_MON0:
> + case AFE_DAC_CON0:
> case AFE_DL2_CUR:
> case AFE_DL3_CUR:
> case AFE_DL6_CUR:
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-01 4:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-01 3:10 [PATCH 1/1] ASoC: mediatek: mt8188: add register to volatile_register yr.yang
2024-08-01 4:01 ` Chen-Yu Tsai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®