* [PATCH v2] leds: lm3601x: Reset led controller during init
@ 2024-08-01 15:30 Jack Chen
2024-08-05 14:15 ` (subset) " Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Jack Chen @ 2024-08-01 15:30 UTC (permalink / raw)
To: Pavel Machek, Lee Jones
Cc: Mark Brown, Vadim Pasternak, Randy Dunlap, Jack Chen,
linux-kernel, linux-leds
LED controller should be reset during initialization to avoid abnormal
behaviors. For example, when power to SoC is recycled but power to LED
controller is not, LED controller should not presume to be in original
state.
Signed-off-by: Jack Chen <zenghuchen@google.com>
---
drivers/leds/flash/leds-lm3601x.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/leds/flash/leds-lm3601x.c b/drivers/leds/flash/leds-lm3601x.c
index 7e93c447fec5..148e48624cd9 100644
--- a/drivers/leds/flash/leds-lm3601x.c
+++ b/drivers/leds/flash/leds-lm3601x.c
@@ -434,6 +434,10 @@ static int lm3601x_probe(struct i2c_client *client)
return ret;
}
+ ret = regmap_write(led->regmap, LM3601X_DEV_ID_REG, LM3601X_SW_RESET);
+ if (ret)
+ dev_warn(&client->dev, "Failed to reset the LED controller\n");
+
mutex_init(&led->lock);
return lm3601x_register_leds(led, fwnode);
--
2.46.0.rc1.232.g9752f9e123-goog
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: (subset) [PATCH v2] leds: lm3601x: Reset led controller during init
2024-08-01 15:30 [PATCH v2] leds: lm3601x: Reset led controller during init Jack Chen
@ 2024-08-05 14:15 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2024-08-05 14:15 UTC (permalink / raw)
To: Pavel Machek, Lee Jones, Jack Chen
Cc: Mark Brown, Vadim Pasternak, Randy Dunlap, linux-kernel, linux-leds
On Thu, 01 Aug 2024 11:30:48 -0400, Jack Chen wrote:
> LED controller should be reset during initialization to avoid abnormal
> behaviors. For example, when power to SoC is recycled but power to LED
> controller is not, LED controller should not presume to be in original
> state.
>
>
Applied, thanks!
[1/1] leds: lm3601x: Reset led controller during init
commit: 70a4375e07fcbb771809f0af8b5f0df029ca660f
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-05 14:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-01 15:30 [PATCH v2] leds: lm3601x: Reset led controller during init Jack Chen
2024-08-05 14:15 ` (subset) " Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®