* [PATCH v3 1/1] dt-bindings: dma: fsl-mxs-dma: Add compatible string "fsl,imx8qxp-dma-apbh"
@ 2024-08-01 21:46 Frank Li
2024-08-26 16:31 ` Frank Li
2024-08-28 18:16 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Frank Li @ 2024-08-01 21:46 UTC (permalink / raw)
To: miquel.raynal, vkoul
Cc: Frank.Li, conor+dt, devicetree, dmaengine, festevam, han.xu, imx,
kernel, krzk+dt, linux-arm-kernel, linux-kernel, linux-mtd,
marex, richard, robh, s.hauer, shawnguo, vigneshr
Add compatible string "fsl,imx8qxp-dma-apbh". It requires power-domains
compared with "fsl,imx28-dma-apbh".
Allow 'power-domains' property because i.MX8DXL i.MX8QM and i.MX8QXP need
it.
Keep the same restriction about 'power-domains' for other compatible
strings.
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Change from v2 to v3
- Add rob's review tag
- resend because it is dropped from mtd tree at
https://lore.kernel.org/imx/20240717103846.306bf9fd@xps-13/
---
.../devicetree/bindings/dma/fsl,mxs-dma.yaml | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml b/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml
index add9c77e8b52a..a17cf2360dd4a 100644
--- a/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml
+++ b/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml
@@ -11,6 +11,17 @@ maintainers:
allOf:
- $ref: dma-controller.yaml#
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: fsl,imx8qxp-dma-apbh
+ then:
+ required:
+ - power-domains
+ else:
+ properties:
+ power-domains: false
properties:
compatible:
@@ -20,6 +31,7 @@ properties:
- fsl,imx6q-dma-apbh
- fsl,imx6sx-dma-apbh
- fsl,imx7d-dma-apbh
+ - fsl,imx8qxp-dma-apbh
- const: fsl,imx28-dma-apbh
- enum:
- fsl,imx23-dma-apbh
@@ -42,6 +54,9 @@ properties:
dma-channels:
enum: [4, 8, 16]
+ power-domains:
+ maxItems: 1
+
required:
- compatible
- reg
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3 1/1] dt-bindings: dma: fsl-mxs-dma: Add compatible string "fsl,imx8qxp-dma-apbh"
2024-08-01 21:46 [PATCH v3 1/1] dt-bindings: dma: fsl-mxs-dma: Add compatible string "fsl,imx8qxp-dma-apbh" Frank Li
@ 2024-08-26 16:31 ` Frank Li
2024-08-28 18:16 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Frank Li @ 2024-08-26 16:31 UTC (permalink / raw)
To: miquel.raynal, vkoul
Cc: conor+dt, devicetree, dmaengine, festevam, han.xu, imx, kernel,
krzk+dt, linux-arm-kernel, linux-kernel, linux-mtd, marex,
richard, robh, s.hauer, shawnguo, vigneshr
On Thu, Aug 01, 2024 at 05:46:01PM -0400, Frank Li wrote:
> Add compatible string "fsl,imx8qxp-dma-apbh". It requires power-domains
> compared with "fsl,imx28-dma-apbh".
>
> Allow 'power-domains' property because i.MX8DXL i.MX8QM and i.MX8QXP need
> it.
>
> Keep the same restriction about 'power-domains' for other compatible
> strings.
>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
vkoul:
Could you please take care this patch?
Frank
> Change from v2 to v3
> - Add rob's review tag
> - resend because it is dropped from mtd tree at
> https://lore.kernel.org/imx/20240717103846.306bf9fd@xps-13/
> ---
> .../devicetree/bindings/dma/fsl,mxs-dma.yaml | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml b/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml
> index add9c77e8b52a..a17cf2360dd4a 100644
> --- a/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml
> +++ b/Documentation/devicetree/bindings/dma/fsl,mxs-dma.yaml
> @@ -11,6 +11,17 @@ maintainers:
>
> allOf:
> - $ref: dma-controller.yaml#
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: fsl,imx8qxp-dma-apbh
> + then:
> + required:
> + - power-domains
> + else:
> + properties:
> + power-domains: false
>
> properties:
> compatible:
> @@ -20,6 +31,7 @@ properties:
> - fsl,imx6q-dma-apbh
> - fsl,imx6sx-dma-apbh
> - fsl,imx7d-dma-apbh
> + - fsl,imx8qxp-dma-apbh
> - const: fsl,imx28-dma-apbh
> - enum:
> - fsl,imx23-dma-apbh
> @@ -42,6 +54,9 @@ properties:
> dma-channels:
> enum: [4, 8, 16]
>
> + power-domains:
> + maxItems: 1
> +
> required:
> - compatible
> - reg
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3 1/1] dt-bindings: dma: fsl-mxs-dma: Add compatible string "fsl,imx8qxp-dma-apbh"
2024-08-01 21:46 [PATCH v3 1/1] dt-bindings: dma: fsl-mxs-dma: Add compatible string "fsl,imx8qxp-dma-apbh" Frank Li
2024-08-26 16:31 ` Frank Li
@ 2024-08-28 18:16 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2024-08-28 18:16 UTC (permalink / raw)
To: miquel.raynal, Frank Li
Cc: conor+dt, devicetree, dmaengine, festevam, han.xu, imx, kernel,
krzk+dt, linux-arm-kernel, linux-kernel, linux-mtd, marex,
richard, robh, s.hauer, shawnguo, vigneshr
On Thu, 01 Aug 2024 17:46:01 -0400, Frank Li wrote:
> Add compatible string "fsl,imx8qxp-dma-apbh". It requires power-domains
> compared with "fsl,imx28-dma-apbh".
>
> Allow 'power-domains' property because i.MX8DXL i.MX8QM and i.MX8QXP need
> it.
>
> Keep the same restriction about 'power-domains' for other compatible
> strings.
>
> [...]
Applied, thanks!
[1/1] dt-bindings: dma: fsl-mxs-dma: Add compatible string "fsl,imx8qxp-dma-apbh"
commit: 63556df6acdd737b75d9a7a8b906cd1c1bc8e2aa
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-28 18:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-01 21:46 [PATCH v3 1/1] dt-bindings: dma: fsl-mxs-dma: Add compatible string "fsl,imx8qxp-dma-apbh" Frank Li
2024-08-26 16:31 ` Frank Li
2024-08-28 18:16 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®