From: Ma Ke <make24@iscas.ac.cn>
To: miriam.rachel.korenblit@intel.com, kvalo@kernel.org,
johannes.berg@intel.com, gregory.greenman@intel.com,
benjamin.berg@intel.com, daniel.gabay@intel.com,
make24@iscas.ac.cn, dan.carpenter@linaro.org
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH RESEND] wifi: iwlwifi: mvm: fix an error code in iwl_mvm_alloc_sta_after_restart()
Date: Fri, 2 Aug 2024 12:27:40 +0800 [thread overview]
Message-ID: <20240802042740.1567091-1-make24@iscas.ac.cn> (raw)
This error path should return -EINVAL instead of success.
Fixes: 57974a55d995 ("wifi: iwlwifi: mvm: refactor iwl_mvm_mac_sta_state_common()")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
---
drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c b/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c
index d5a204e52076..477239a1ed83 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/mld-sta.c
@@ -644,12 +644,12 @@ static int iwl_mvm_alloc_sta_after_restart(struct iwl_mvm *mvm,
lockdep_is_held(&mvm->mutex));
if (!link_conf)
- continue;
+ return -EINVAL;
mvm_link = mvmvif->link[link_conf->link_id];
if (!mvm_link || !mvm_link_sta)
- continue;
+ return -EINVAL;
sta_id = mvm_link_sta->sta_id;
ret = iwl_mvm_mld_cfg_sta(mvm, sta, vif, link_sta,
--
2.25.1
next reply other threads:[~2024-08-02 4:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 4:27 Ma Ke [this message]
2024-08-02 5:09 ` Dan Carpenter
2024-08-23 3:04 ` Ma Ke
2024-08-23 5:56 ` Kalle Valo
2024-08-23 9:03 ` Dan Carpenter
2024-08-23 9:14 ` Dan Carpenter
2024-08-23 9:29 ` Berg, Benjamin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240802042740.1567091-1-make24@iscas.ac.cn \
--to=make24@iscas.ac.cn \
--cc=benjamin.berg@intel.com \
--cc=dan.carpenter@linaro.org \
--cc=daniel.gabay@intel.com \
--cc=gregory.greenman@intel.com \
--cc=johannes.berg@intel.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®