From: Ma Ke <make24@iscas.ac.cn>
To: dan.carpenter@linaro.org
Cc: benjamin.berg@intel.com, daniel.gabay@intel.com,
gregory.greenman@intel.com, johannes.berg@intel.com,
kvalo@kernel.org, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org, make24@iscas.ac.cn,
miriam.rachel.korenblit@intel.com
Subject: Re: [PATCH RESEND] wifi: iwlwifi: mvm: fix an error code in iwl_mvm_alloc_sta_after_restart()
Date: Fri, 23 Aug 2024 11:04:23 +0800 [thread overview]
Message-ID: <20240823030423.1781977-1-make24@iscas.ac.cn> (raw)
In-Reply-To: <575625da-60bc-4444-a5f3-a7acf925f1e5@suswa.mountain>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1764 bytes --]
Dan Carpenter<dan.carpenter@linaro.org> wrote:
> The Subject says RESEND but doesn't explain why you are resending.
> You probably meant v2, but again it needs an explanation.
>
> On Fri, Aug 02, 2024 at 12:27:40PM +0800, Ma Ke wrote:
> > This error path should return -EINVAL instead of success.
>
> Why do you feel that way? Have you tested it? What is the user visible
> effect of this bug?
>
> I slightly feel hypocritical because I have send lots of commit messages
> with exactly this commit message. The difference is that I only send
> really easy patches where it's obvious what the intent was. A normal
> kernel developer wouldn't need to leave their email client or view any
> outside information to see that my patch is correct. If a patch is not
> dead easy, I normally just report it. (Sometimes I report dead easy
> bugs as well because I am lazy and maybe it's the end of my work day
> or whatever).
>
> This patch on the other hand is more subtle and it's not clear why the
> continue statements changed into returns.
>
> regards,
> dan carpenter
Thank you for your response to the vulnerability I submitted. Yes, we
believe there is a similar issue. As described in [1], it gets pointers
which are handled under the protection mechanism. If the path is error, it
should return -EINVAL directly instead of success. The discovery of this
problem was confirmed through manual review of the code and compilation
testing. And by the way, I resent the patch because I hadn’t received a
reply for a long time, so I resent it.
[1] https://lore.kernel.org/all/MW5PR11MB58102E1897D7437CD8E1DF27A3DDA@MW5PR11MB5810.namprd11.prod.outlook.com/
--
Regards,
Ma Ke
next prev parent reply other threads:[~2024-08-23 3:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 4:27 Ma Ke
2024-08-02 5:09 ` Dan Carpenter
2024-08-23 3:04 ` Ma Ke [this message]
2024-08-23 5:56 ` Kalle Valo
2024-08-23 9:03 ` Dan Carpenter
2024-08-23 9:14 ` Dan Carpenter
2024-08-23 9:29 ` Berg, Benjamin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240823030423.1781977-1-make24@iscas.ac.cn \
--to=make24@iscas.ac.cn \
--cc=benjamin.berg@intel.com \
--cc=dan.carpenter@linaro.org \
--cc=daniel.gabay@intel.com \
--cc=gregory.greenman@intel.com \
--cc=johannes.berg@intel.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®