From: Pedro Falcato <pedro.falcato@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
oliver.sang@intel.com, torvalds@linux-foundation.org,
jeffxu@google.com, Michael Ellerman <mpe@ellerman.id.au>,
Pedro Falcato <pedro.falcato@gmail.com>
Subject: [PATCH 3/7] mm/mprotect: Replace can_modify_mm with can_modify_vma
Date: Tue, 6 Aug 2024 22:28:04 +0100 [thread overview]
Message-ID: <20240806212808.1885309-4-pedro.falcato@gmail.com> (raw)
In-Reply-To: <20240806212808.1885309-1-pedro.falcato@gmail.com>
Avoid taking an extra trip down the mmap tree by checking the vmas
directly. mprotect (per POSIX) tolerates partial failure.
Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com>
---
mm/mprotect.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/mm/mprotect.c b/mm/mprotect.c
index 222ab434da5..b1980ea1cc3 100644
--- a/mm/mprotect.c
+++ b/mm/mprotect.c
@@ -589,6 +589,9 @@ mprotect_fixup(struct vma_iterator *vmi, struct mmu_gather *tlb,
unsigned long charged = 0;
int error;
+ if (!can_modify_vma(vma))
+ return -EPERM;
+
if (newflags == oldflags) {
*pprev = vma;
return 0;
@@ -747,15 +750,6 @@ static int do_mprotect_pkey(unsigned long start, size_t len,
}
}
- /*
- * checking if memory is sealed.
- * can_modify_mm assumes we have acquired the lock on MM.
- */
- if (unlikely(!can_modify_mm(current->mm, start, end))) {
- error = -EPERM;
- goto out;
- }
-
prev = vma_prev(&vmi);
if (start > vma->vm_start)
prev = vma;
--
2.46.0
next prev parent reply other threads:[~2024-08-06 21:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 21:28 [PATCH 0/7] mm: Optimize mseal checks Pedro Falcato
2024-08-06 21:28 ` [PATCH 1/7] mm: Move can_modify_vma to mm/internal.h Pedro Falcato
2024-08-06 21:28 ` [PATCH 2/7] mm/munmap: Replace can_modify_mm with can_modify_vma Pedro Falcato
2024-08-07 13:02 ` Lorenzo Stoakes
2024-08-07 13:13 ` Pedro Falcato
2024-08-06 21:28 ` Pedro Falcato [this message]
2024-08-06 21:28 ` [PATCH 4/7] mm/mremap: " Pedro Falcato
2024-08-06 23:09 ` Jeff Xu
2024-08-07 0:59 ` Pedro Falcato
2024-08-07 1:47 ` Jeff Xu
2024-08-06 21:28 ` [PATCH 5/7] mseal: Fix is_madv_discard() Pedro Falcato
2024-08-07 13:13 ` Lorenzo Stoakes
2024-08-06 21:28 ` [PATCH 6/7] mseal: Replace can_modify_mm_madv with a vma variant Pedro Falcato
2024-08-06 21:28 ` [PATCH 7/7] mm: Remove can_modify_mm() Pedro Falcato
2024-08-06 22:24 ` [PATCH 0/7] mm: Optimize mseal checks Jeff Xu
2024-08-07 0:49 ` Pedro Falcato
2024-08-07 1:39 ` Jeff Xu
2024-08-07 12:56 ` Pedro Falcato
2024-08-07 14:15 ` Jeff Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240806212808.1885309-4-pedro.falcato@gmail.com \
--to=pedro.falcato@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jeffxu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mpe@ellerman.id.au \
--cc=oliver.sang@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®