From: Pedro Falcato <pedro.falcato@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
oliver.sang@intel.com, torvalds@linux-foundation.org,
jeffxu@google.com, Michael Ellerman <mpe@ellerman.id.au>,
Pedro Falcato <pedro.falcato@gmail.com>
Subject: [PATCH 7/7] mm: Remove can_modify_mm()
Date: Tue, 6 Aug 2024 22:28:08 +0100 [thread overview]
Message-ID: <20240806212808.1885309-8-pedro.falcato@gmail.com> (raw)
In-Reply-To: <20240806212808.1885309-1-pedro.falcato@gmail.com>
With no more users in the tree, we can finally remove can_modify_mm().
Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com>
---
mm/internal.h | 8 --------
mm/mseal.c | 21 ---------------------
2 files changed, 29 deletions(-)
diff --git a/mm/internal.h b/mm/internal.h
index 4b516618389..e4416f5da2f 100644
--- a/mm/internal.h
+++ b/mm/internal.h
@@ -1515,8 +1515,6 @@ static inline bool can_modify_vma(struct vm_area_struct *vma)
}
-bool can_modify_mm(struct mm_struct *mm, unsigned long start,
- unsigned long end);
bool can_modify_vma_madv(struct vm_area_struct *vma, int behavior);
#else
static inline int can_do_mseal(unsigned long flags)
@@ -1524,12 +1522,6 @@ static inline int can_do_mseal(unsigned long flags)
return -EPERM;
}
-static inline bool can_modify_mm(struct mm_struct *mm, unsigned long start,
- unsigned long end)
-{
- return true;
-}
-
static inline bool can_modify_vma_madv(struct vm_area_struct *vma, int behavior)
{
return true;
diff --git a/mm/mseal.c b/mm/mseal.c
index fdd1666344f..28cd17d7aaf 100644
--- a/mm/mseal.c
+++ b/mm/mseal.c
@@ -53,27 +53,6 @@ static bool is_ro_anon(struct vm_area_struct *vma)
return false;
}
-/*
- * Check if the vmas of a memory range are allowed to be modified.
- * the memory ranger can have a gap (unallocated memory).
- * return true, if it is allowed.
- */
-bool can_modify_mm(struct mm_struct *mm, unsigned long start, unsigned long end)
-{
- struct vm_area_struct *vma;
-
- VMA_ITERATOR(vmi, mm, start);
-
- /* going through each vma to check. */
- for_each_vma_range(vmi, vma, end) {
- if (unlikely(!can_modify_vma(vma)))
- return false;
- }
-
- /* Allow by default. */
- return true;
-}
-
/*
* Check if a vma is allowed to be modified by madvise.
*/
--
2.46.0
next prev parent reply other threads:[~2024-08-06 21:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 21:28 [PATCH 0/7] mm: Optimize mseal checks Pedro Falcato
2024-08-06 21:28 ` [PATCH 1/7] mm: Move can_modify_vma to mm/internal.h Pedro Falcato
2024-08-06 21:28 ` [PATCH 2/7] mm/munmap: Replace can_modify_mm with can_modify_vma Pedro Falcato
2024-08-07 13:02 ` Lorenzo Stoakes
2024-08-07 13:13 ` Pedro Falcato
2024-08-06 21:28 ` [PATCH 3/7] mm/mprotect: " Pedro Falcato
2024-08-06 21:28 ` [PATCH 4/7] mm/mremap: " Pedro Falcato
2024-08-06 23:09 ` Jeff Xu
2024-08-07 0:59 ` Pedro Falcato
2024-08-07 1:47 ` Jeff Xu
2024-08-06 21:28 ` [PATCH 5/7] mseal: Fix is_madv_discard() Pedro Falcato
2024-08-07 13:13 ` Lorenzo Stoakes
2024-08-06 21:28 ` [PATCH 6/7] mseal: Replace can_modify_mm_madv with a vma variant Pedro Falcato
2024-08-06 21:28 ` Pedro Falcato [this message]
2024-08-06 22:24 ` [PATCH 0/7] mm: Optimize mseal checks Jeff Xu
2024-08-07 0:49 ` Pedro Falcato
2024-08-07 1:39 ` Jeff Xu
2024-08-07 12:56 ` Pedro Falcato
2024-08-07 14:15 ` Jeff Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240806212808.1885309-8-pedro.falcato@gmail.com \
--to=pedro.falcato@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jeffxu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mpe@ellerman.id.au \
--cc=oliver.sang@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®