Re: [PATCH 1/2] dt-bindings: adc: ad7173: add support for ad4113

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1913 bytes --]

On Wed, Aug 07, 2024 at 05:58:04PM +0300, Dumitru Ceclan wrote:
> This commit adds bindings support for AD4113.
> 
> The AD4113 is a low power, low noise, 16-bit, Σ-Δ analog-to-digital
> converter (ADC) that integrates an analog front end (AFE) for four
> fully differential or eight single-ended inputs.

You should highlight why it is incompatible from existing devices, it's
not clear from the description/diff.

> 
> Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com>
> ---
>  Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
> index 17c5d39cc2c1..ad15cf9bc2ff 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7173.yaml
> @@ -28,6 +28,7 @@ description: |
>    Datasheets for supported chips:
>      https://www.analog.com/media/en/technical-documentation/data-sheets/AD4111.pdf
>      https://www.analog.com/media/en/technical-documentation/data-sheets/AD4112.pdf
> +    <AD4113: not released yet>
>      https://www.analog.com/media/en/technical-documentation/data-sheets/AD4114.pdf
>      https://www.analog.com/media/en/technical-documentation/data-sheets/AD4115.pdf
>      https://www.analog.com/media/en/technical-documentation/data-sheets/AD4116.pdf
> @@ -44,6 +45,7 @@ properties:
>      enum:
>        - adi,ad4111
>        - adi,ad4112
> +      - adi,ad4113
>        - adi,ad4114
>        - adi,ad4115
>        - adi,ad4116
> @@ -331,6 +333,7 @@ allOf:
>              enum:
>                - adi,ad4111
>                - adi,ad4112
> +              - adi,ad4113
>                - adi,ad4114
>                - adi,ad4115
>                - adi,ad4116
> 
> -- 
> 2.43.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]