* [PATCH] Documentation: dm-crypt.rst warning + error fix
@ 2024-08-07 9:01 Daniel Yang
2024-08-07 19:33 ` Jonathan Corbet
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Yang @ 2024-08-07 9:01 UTC (permalink / raw)
To: skhan
Cc: danielyangkang, Alasdair Kergon, Mike Snitzer, Mikulas Patocka,
Jonathan Corbet, dm-devel, linux-doc, linux-kernel
Signed-off-by: Daniel Yang <danielyangkang@gmail.com>
---
.../admin-guide/device-mapper/dm-crypt.rst | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/Documentation/admin-guide/device-mapper/dm-crypt.rst b/Documentation/admin-guide/device-mapper/dm-crypt.rst
index e625830d335..552c9155165 100644
--- a/Documentation/admin-guide/device-mapper/dm-crypt.rst
+++ b/Documentation/admin-guide/device-mapper/dm-crypt.rst
@@ -162,13 +162,14 @@ iv_large_sectors
Module parameters::
-max_read_size
-max_write_size
- Maximum size of read or write requests. When a request larger than this size
- is received, dm-crypt will split the request. The splitting improves
- concurrency (the split requests could be encrypted in parallel by multiple
- cores), but it also causes overhead. The user should tune these parameters to
- fit the actual workload.
+
+ max_read_size
+ max_write_size
+ Maximum size of read or write requests. When a request larger than this size
+ is received, dm-crypt will split the request. The splitting improves
+ concurrency (the split requests could be encrypted in parallel by multiple
+ cores), but it also causes overhead. The user should tune these parameters to
+ fit the actual workload.
Example scripts
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Documentation: dm-crypt.rst warning + error fix
2024-08-07 9:01 [PATCH] Documentation: dm-crypt.rst warning + error fix Daniel Yang
@ 2024-08-07 19:33 ` Jonathan Corbet
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Corbet @ 2024-08-07 19:33 UTC (permalink / raw)
To: Daniel Yang, skhan
Cc: danielyangkang, Alasdair Kergon, Mike Snitzer, Mikulas Patocka,
dm-devel, linux-doc, linux-kernel
Daniel Yang <danielyangkang@gmail.com> writes:
> Signed-off-by: Daniel Yang <danielyangkang@gmail.com>
> ---
> .../admin-guide/device-mapper/dm-crypt.rst | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/admin-guide/device-mapper/dm-crypt.rst b/Documentation/admin-guide/device-mapper/dm-crypt.rst
> index e625830d335..552c9155165 100644
> --- a/Documentation/admin-guide/device-mapper/dm-crypt.rst
> +++ b/Documentation/admin-guide/device-mapper/dm-crypt.rst
> @@ -162,13 +162,14 @@ iv_large_sectors
>
>
> Module parameters::
> -max_read_size
> -max_write_size
> - Maximum size of read or write requests. When a request larger than this size
> - is received, dm-crypt will split the request. The splitting improves
> - concurrency (the split requests could be encrypted in parallel by multiple
> - cores), but it also causes overhead. The user should tune these parameters to
> - fit the actual workload.
> +
> + max_read_size
> + max_write_size
> + Maximum size of read or write requests. When a request larger than this size
> + is received, dm-crypt will split the request. The splitting improves
> + concurrency (the split requests could be encrypted in parallel by multiple
> + cores), but it also causes overhead. The user should tune these parameters to
> + fit the actual workload.
Thanks for the patch. It would have been better to include a proper
changelog, even for a simple change like this. Unfortunately, I got
another fix for this error a few days ago, and have applied that.
jon
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-07 19:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-07 9:01 [PATCH] Documentation: dm-crypt.rst warning + error fix Daniel Yang
2024-08-07 19:33 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®