mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pedro Falcato <pedro.falcato@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	oliver.sang@intel.com, torvalds@linux-foundation.org,
	jeffxu@google.com, Michael Ellerman <mpe@ellerman.id.au>,
	Pedro Falcato <pedro.falcato@gmail.com>
Subject: [PATCH v2 0/6] mm: Optimize mseal checks
Date: Wed,  7 Aug 2024 22:13:03 +0100	[thread overview]
Message-ID: <20240807211309.2729719-1-pedro.falcato@gmail.com> (raw)

[based on mm-unstable, 98808d08]

Optimize mseal checks by removing the separate can_modify_mm() step, and
just doing checks on the individual vmas, when various operations are
themselves iterating through the tree. This provides a nice speedup and restores
performance parity with pre-mseal[3].

This series also depends on (and will eventually very slightly conflict with)
the powerpc series that removes arch_unmap[2].

will-it-scale mmap1_process[1] -t 1 results:

commit 3450fe2b574b4345e4296ccae395149e1a357fee:

min:277605 max:277605 total:277605
min:281784 max:281784 total:281784
min:277238 max:277238 total:277238
min:281761 max:281761 total:281761
min:274279 max:274279 total:274279
min:254854 max:254854 total:254854
measurement
min:269143 max:269143 total:269143
min:270454 max:270454 total:270454
min:243523 max:243523 total:243523
min:251148 max:251148 total:251148
min:209669 max:209669 total:209669
min:190426 max:190426 total:190426
min:231219 max:231219 total:231219
min:275364 max:275364 total:275364
min:266540 max:266540 total:266540
min:242572 max:242572 total:242572
min:284469 max:284469 total:284469
min:278882 max:278882 total:278882
min:283269 max:283269 total:283269
min:281204 max:281204 total:281204

After this patch set:

min:280580 max:280580 total:280580
min:290514 max:290514 total:290514
min:291006 max:291006 total:291006
min:290352 max:290352 total:290352
min:294582 max:294582 total:294582
min:293075 max:293075 total:293075
measurement
min:295613 max:295613 total:295613
min:294070 max:294070 total:294070
min:293193 max:293193 total:293193
min:291631 max:291631 total:291631
min:295278 max:295278 total:295278
min:293782 max:293782 total:293782
min:290361 max:290361 total:290361
min:294517 max:294517 total:294517
min:293750 max:293750 total:293750
min:293572 max:293572 total:293572
min:295239 max:295239 total:295239
min:292932 max:292932 total:292932
min:293319 max:293319 total:293319
min:294954 max:294954 total:294954

This was a Completely Unscientific test but seems to show there were around 5-10% gains on ops per second.

Oliver performed his own tests and showed[3] a similar ~5% gain in them.

[1]: mmap1_process does mmap and munmap in a loop. I didn't bother testing multithreading cases.
[2]: https://lore.kernel.org/all/20240807124103.85644-1-mpe@ellerman.id.au/
[3]: https://lore.kernel.org/all/ZrMMJfe9aXSWxJz6@xsang-OptiPlex-9020/
Link: https://lore.kernel.org/all/202408041602.caa0372-oliver.sang@intel.com/

Changes in v2:
 - Rebased on top of mm-unstable
 - Removed a superfluous check in mremap (Jeff Xu)

Pedro Falcato (6):
  mm: Move can_modify_vma to mm/internal.h
  mm/munmap: Replace can_modify_mm with can_modify_vma
  mm/mprotect: Replace can_modify_mm with can_modify_vma
  mm/mremap: Replace can_modify_mm with can_modify_vma
  mseal: Replace can_modify_mm_madv with a vma variant
  mm: Remove can_modify_mm()

 mm/internal.h | 30 ++++++++++++++++++++--------
 mm/madvise.c  | 13 +++---------
 mm/mmap.c     | 13 +-----------
 mm/mprotect.c | 12 +++--------
 mm/mremap.c   | 30 ++++------------------------
 mm/mseal.c    | 55 ++++-----------------------------------------------
 mm/vma.c      | 23 ++++++++++-----------
 7 files changed, 49 insertions(+), 127 deletions(-)


base-commit: 98808d08fc0f78ee638e0c0a88020fbbaf581ec6
-- 
2.46.0


             reply	other threads:[~2024-08-07 21:13 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-07 21:13 Pedro Falcato [this message]
2024-08-07 21:13 ` [PATCH v2 1/6] mm: Move can_modify_vma to mm/internal.h Pedro Falcato
2024-08-09  9:57   ` Lorenzo Stoakes
2024-08-07 21:13 ` [PATCH v2 2/6] mm/munmap: Replace can_modify_mm with can_modify_vma Pedro Falcato
2024-08-09 16:15   ` Liam R. Howlett
2024-08-09 16:48     ` Liam R. Howlett
2024-08-09 18:53       ` Pedro Falcato
2024-08-09 19:24         ` Liam R. Howlett
2024-08-12 14:30           ` Jeff Xu
2024-08-12 16:57             ` Liam R. Howlett
2024-08-12 17:38               ` Jeff Xu
2024-08-12 19:25                 ` Liam R. Howlett
2024-08-07 21:13 ` [PATCH v2 3/6] mm/mprotect: " Pedro Falcato
2024-08-07 21:13 ` [PATCH v2 4/6] mm/mremap: " Pedro Falcato
2024-08-09 16:05   ` Liam R. Howlett
2024-08-09 18:45     ` Pedro Falcato
2024-08-12 15:22       ` Liam R. Howlett
2024-08-07 21:13 ` [PATCH v2 5/6] mseal: Replace can_modify_mm_madv with a vma variant Pedro Falcato
2024-08-09 16:27   ` Liam R. Howlett
2024-08-07 21:13 ` [PATCH v2 6/6] mm: Remove can_modify_mm() Pedro Falcato
2024-08-08 23:12 ` [PATCH v2 0/6] mm: Optimize mseal checks Andrew Morton
2024-08-09  0:34   ` Pedro Falcato
2024-08-09  1:02     ` Jeff Xu
2024-08-09 19:34       ` Liam R. Howlett
2024-08-15 22:10       ` Jeff Xu
2024-08-16  1:58         ` Pedro Falcato
2024-08-16 17:07           ` Jeff Xu
2024-08-16 18:09             ` Pedro Falcato
2024-08-16 18:20               ` Jeff Xu
2024-08-16 18:26                 ` Pedro Falcato
2024-08-16 18:42                   ` Jeff Xu
2024-08-16 17:30           ` Jeff Xu
2024-08-15 21:11 ` Jeff Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240807211309.2729719-1-pedro.falcato@gmail.com \
    --to=pedro.falcato@gmail.com \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=jeffxu@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=mpe@ellerman.id.au \
    --cc=oliver.sang@intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®