From: Pedro Falcato <pedro.falcato@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
oliver.sang@intel.com, torvalds@linux-foundation.org,
jeffxu@google.com, Michael Ellerman <mpe@ellerman.id.au>,
Pedro Falcato <pedro.falcato@gmail.com>
Subject: [PATCH v2 1/6] mm: Move can_modify_vma to mm/internal.h
Date: Wed, 7 Aug 2024 22:13:04 +0100 [thread overview]
Message-ID: <20240807211309.2729719-2-pedro.falcato@gmail.com> (raw)
In-Reply-To: <20240807211309.2729719-1-pedro.falcato@gmail.com>
Move can_modify_vma to internal.h so it can be inlined properly (with
the intent to remove can_modify_mm callsites).
Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com>
---
mm/internal.h | 24 ++++++++++++++++++++++++
mm/mseal.c | 17 -----------------
2 files changed, 24 insertions(+), 17 deletions(-)
diff --git a/mm/internal.h b/mm/internal.h
index 52f7fc4e8ac..90f50f3c4cf 100644
--- a/mm/internal.h
+++ b/mm/internal.h
@@ -1353,6 +1353,24 @@ static inline int can_do_mseal(unsigned long flags)
return 0;
}
+static inline bool vma_is_sealed(struct vm_area_struct *vma)
+{
+ return (vma->vm_flags & VM_SEALED);
+}
+
+/*
+ * check if a vma is sealed for modification.
+ * return true, if modification is allowed.
+ */
+static inline bool can_modify_vma(struct vm_area_struct *vma)
+{
+ if (unlikely(vma_is_sealed(vma)))
+ return false;
+
+ return true;
+}
+
+
bool can_modify_mm(struct mm_struct *mm, unsigned long start,
unsigned long end);
bool can_modify_mm_madv(struct mm_struct *mm, unsigned long start,
@@ -1374,6 +1392,12 @@ static inline bool can_modify_mm_madv(struct mm_struct *mm, unsigned long start,
{
return true;
}
+
+static inline bool can_modify_vma(struct vm_area_struct *vma)
+{
+ return true;
+}
+
#endif
#ifdef CONFIG_SHRINKER_DEBUG
diff --git a/mm/mseal.c b/mm/mseal.c
index bf783bba8ed..4591ae8d29c 100644
--- a/mm/mseal.c
+++ b/mm/mseal.c
@@ -16,28 +16,11 @@
#include <linux/sched.h>
#include "internal.h"
-static inline bool vma_is_sealed(struct vm_area_struct *vma)
-{
- return (vma->vm_flags & VM_SEALED);
-}
-
static inline void set_vma_sealed(struct vm_area_struct *vma)
{
vm_flags_set(vma, VM_SEALED);
}
-/*
- * check if a vma is sealed for modification.
- * return true, if modification is allowed.
- */
-static bool can_modify_vma(struct vm_area_struct *vma)
-{
- if (unlikely(vma_is_sealed(vma)))
- return false;
-
- return true;
-}
-
static bool is_madv_discard(int behavior)
{
return behavior &
--
2.46.0
next prev parent reply other threads:[~2024-08-07 21:13 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 21:13 [PATCH v2 0/6] mm: Optimize mseal checks Pedro Falcato
2024-08-07 21:13 ` Pedro Falcato [this message]
2024-08-09 9:57 ` [PATCH v2 1/6] mm: Move can_modify_vma to mm/internal.h Lorenzo Stoakes
2024-08-07 21:13 ` [PATCH v2 2/6] mm/munmap: Replace can_modify_mm with can_modify_vma Pedro Falcato
2024-08-09 16:15 ` Liam R. Howlett
2024-08-09 16:48 ` Liam R. Howlett
2024-08-09 18:53 ` Pedro Falcato
2024-08-09 19:24 ` Liam R. Howlett
2024-08-12 14:30 ` Jeff Xu
2024-08-12 16:57 ` Liam R. Howlett
2024-08-12 17:38 ` Jeff Xu
2024-08-12 19:25 ` Liam R. Howlett
2024-08-07 21:13 ` [PATCH v2 3/6] mm/mprotect: " Pedro Falcato
2024-08-07 21:13 ` [PATCH v2 4/6] mm/mremap: " Pedro Falcato
2024-08-09 16:05 ` Liam R. Howlett
2024-08-09 18:45 ` Pedro Falcato
2024-08-12 15:22 ` Liam R. Howlett
2024-08-07 21:13 ` [PATCH v2 5/6] mseal: Replace can_modify_mm_madv with a vma variant Pedro Falcato
2024-08-09 16:27 ` Liam R. Howlett
2024-08-07 21:13 ` [PATCH v2 6/6] mm: Remove can_modify_mm() Pedro Falcato
2024-08-08 23:12 ` [PATCH v2 0/6] mm: Optimize mseal checks Andrew Morton
2024-08-09 0:34 ` Pedro Falcato
2024-08-09 1:02 ` Jeff Xu
2024-08-09 19:34 ` Liam R. Howlett
2024-08-15 22:10 ` Jeff Xu
2024-08-16 1:58 ` Pedro Falcato
2024-08-16 17:07 ` Jeff Xu
2024-08-16 18:09 ` Pedro Falcato
2024-08-16 18:20 ` Jeff Xu
2024-08-16 18:26 ` Pedro Falcato
2024-08-16 18:42 ` Jeff Xu
2024-08-16 17:30 ` Jeff Xu
2024-08-15 21:11 ` Jeff Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240807211309.2729719-2-pedro.falcato@gmail.com \
--to=pedro.falcato@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jeffxu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mpe@ellerman.id.au \
--cc=oliver.sang@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®