[PATCH 1/3] genirq/irq_sim: Remove unused irq_sim_work_ctx::irq_base

[PATCH 1/3] genirq/irq_sim: Remove unused irq_sim_work_ctx::irq_base

[Jiri Slaby (SUSE)]

Since commit 337cbeb2c13e ("genirq/irq_sim: Simplify the API"),
irq_sim_work_ctx::irq_base is unused. Drop it.

Found by https://github.com/jirislaby/clang-struct.

Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>
---
 kernel/irq/irq_sim.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/irq/irq_sim.c b/kernel/irq/irq_sim.c
index 3d4036db15ac..1a3d483548e2 100644
--- a/kernel/irq/irq_sim.c
+++ b/kernel/irq/irq_sim.c
@@ -13,7 +13,6 @@
 
 struct irq_sim_work_ctx {
 	struct irq_work		work;
-	int			irq_base;
 	unsigned int		irq_count;
 	unsigned long		*pending;
 	struct irq_domain	*domain;
-- 
2.46.0

[PATCH 2/3] genirq: Remove unused irq_chip_generic::{type,polarity}_cache

[Jiri Slaby (SUSE)]

The type_cache and polarity_cache members of struct irq_chip_generic are
unused. Remove them both along with their kernel-doc.

Found by https://github.com/jirislaby/clang-struct.

Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
---
 include/linux/irq.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/include/linux/irq.h b/include/linux/irq.h
index 1f5dbf1f92c9..00490d6ead65 100644
--- a/include/linux/irq.h
+++ b/include/linux/irq.h
@@ -1040,8 +1040,6 @@ struct irq_chip_type {
  * @irq_base:		Interrupt base nr for this chip
  * @irq_cnt:		Number of interrupts handled by this chip
  * @mask_cache:		Cached mask register shared between all chip types
- * @type_cache:		Cached type register
- * @polarity_cache:	Cached polarity register
  * @wake_enabled:	Interrupt can wakeup from suspend
  * @wake_active:	Interrupt is marked as an wakeup from suspend source
  * @num_ct:		Number of available irq_chip_type instances (usually 1)
@@ -1068,8 +1066,6 @@ struct irq_chip_generic {
 	unsigned int		irq_base;
 	unsigned int		irq_cnt;
 	u32			mask_cache;
-	u32			type_cache;
-	u32			polarity_cache;
 	u32			wake_enabled;
 	u32			wake_active;
 	unsigned int		num_ct;
-- 
2.46.0

[PATCH 3/3] genirq: Remove irq_chip_regs::polarity

[Jiri Slaby (SUSE)]

The polarity member of struct irq_chip_regs is unused. Remove it along
with its kernel-doc.

Found by https://github.com/jirislaby/clang-struct.

Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
---
 include/linux/irq.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/linux/irq.h b/include/linux/irq.h
index 00490d6ead65..fa711f80957b 100644
--- a/include/linux/irq.h
+++ b/include/linux/irq.h
@@ -991,7 +991,6 @@ void irq_init_desc(unsigned int irq);
  * @ack:	Ack register offset to reg_base
  * @eoi:	Eoi register offset to reg_base
  * @type:	Type configuration register offset to reg_base
- * @polarity:	Polarity configuration register offset to reg_base
  */
 struct irq_chip_regs {
 	unsigned long		enable;
@@ -1000,7 +999,6 @@ struct irq_chip_regs {
 	unsigned long		ack;
 	unsigned long		eoi;
 	unsigned long		type;
-	unsigned long		polarity;
 };
 
 /**
-- 
2.46.0

Re: [PATCH 1/3] genirq/irq_sim: Remove unused irq_sim_work_ctx::irq_base

[Bartosz Golaszewski]

On Thu, Aug 8, 2024 at 12:41 PM Jiri Slaby (SUSE) <jirislaby@kernel.org> wrote:
>
> Since commit 337cbeb2c13e ("genirq/irq_sim: Simplify the API"),
> irq_sim_work_ctx::irq_base is unused. Drop it.
>
> Found by https://github.com/jirislaby/clang-struct.
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Bartosz Golaszewski <brgl@bgdev.pl>
> ---
>  kernel/irq/irq_sim.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/kernel/irq/irq_sim.c b/kernel/irq/irq_sim.c
> index 3d4036db15ac..1a3d483548e2 100644
> --- a/kernel/irq/irq_sim.c
> +++ b/kernel/irq/irq_sim.c
> @@ -13,7 +13,6 @@
>
>  struct irq_sim_work_ctx {
>         struct irq_work         work;
> -       int                     irq_base;
>         unsigned int            irq_count;
>         unsigned long           *pending;
>         struct irq_domain       *domain;
> --
> 2.46.0
>

Acked-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

[tip: irq/core] genirq: Remove unused irq_chip_generic:: {type,polarity}_cache

[tip-bot2 for Jiri Slaby (SUSE)]

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     a09cdb8f564613769142a60400bb5160864c3269
Gitweb:        https://git.kernel.org/tip/a09cdb8f564613769142a60400bb5160864c3269
Author:        Jiri Slaby (SUSE) <jirislaby@kernel.org>
AuthorDate:    Thu, 08 Aug 2024 12:41:17 +02:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Thu, 08 Aug 2024 17:15:02 +02:00

genirq: Remove unused irq_chip_generic:: {type,polarity}_cache

The type_cache and polarity_cache members of struct irq_chip_generic are
unused. Remove them both along with their kernel-doc.

Found by https://github.com/jirislaby/clang-struct.

Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20240808104118.430670-2-jirislaby@kernel.org

---
 include/linux/irq.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/include/linux/irq.h b/include/linux/irq.h
index 1f5dbf1..00490d6 100644
--- a/include/linux/irq.h
+++ b/include/linux/irq.h
@@ -1040,8 +1040,6 @@ struct irq_chip_type {
  * @irq_base:		Interrupt base nr for this chip
  * @irq_cnt:		Number of interrupts handled by this chip
  * @mask_cache:		Cached mask register shared between all chip types
- * @type_cache:		Cached type register
- * @polarity_cache:	Cached polarity register
  * @wake_enabled:	Interrupt can wakeup from suspend
  * @wake_active:	Interrupt is marked as an wakeup from suspend source
  * @num_ct:		Number of available irq_chip_type instances (usually 1)
@@ -1068,8 +1066,6 @@ struct irq_chip_generic {
 	unsigned int		irq_base;
 	unsigned int		irq_cnt;
 	u32			mask_cache;
-	u32			type_cache;
-	u32			polarity_cache;
 	u32			wake_enabled;
 	u32			wake_active;
 	unsigned int		num_ct;

[tip: irq/core] genirq: Remove irq_chip_regs:: Polarity

[tip-bot2 for Jiri Slaby (SUSE)]

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     60029162a0458832ab2bcfc6fd4986bfd9ca0f55
Gitweb:        https://git.kernel.org/tip/60029162a0458832ab2bcfc6fd4986bfd9ca0f55
Author:        Jiri Slaby (SUSE) <jirislaby@kernel.org>
AuthorDate:    Thu, 08 Aug 2024 12:41:18 +02:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Thu, 08 Aug 2024 17:15:02 +02:00

genirq: Remove irq_chip_regs:: Polarity

The polarity member of struct irq_chip_regs is unused. Remove it along
with its kernel-doc.

Found by https://github.com/jirislaby/clang-struct.

Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20240808104118.430670-3-jirislaby@kernel.org

---
 include/linux/irq.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/linux/irq.h b/include/linux/irq.h
index 00490d6..fa711f8 100644
--- a/include/linux/irq.h
+++ b/include/linux/irq.h
@@ -991,7 +991,6 @@ void irq_init_desc(unsigned int irq);
  * @ack:	Ack register offset to reg_base
  * @eoi:	Eoi register offset to reg_base
  * @type:	Type configuration register offset to reg_base
- * @polarity:	Polarity configuration register offset to reg_base
  */
 struct irq_chip_regs {
 	unsigned long		enable;
@@ -1000,7 +999,6 @@ struct irq_chip_regs {
 	unsigned long		ack;
 	unsigned long		eoi;
 	unsigned long		type;
-	unsigned long		polarity;
 };
 
 /**

[tip: irq/core] genirq/irq_sim: Remove unused irq_sim_work_ctx:: Irq_base

[tip-bot2 for Jiri Slaby (SUSE)]

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     15e46124ec937bb0ab530634dce4550947f53133
Gitweb:        https://git.kernel.org/tip/15e46124ec937bb0ab530634dce4550947f53133
Author:        Jiri Slaby (SUSE) <jirislaby@kernel.org>
AuthorDate:    Thu, 08 Aug 2024 12:41:16 +02:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Thu, 08 Aug 2024 17:15:01 +02:00

genirq/irq_sim: Remove unused irq_sim_work_ctx:: Irq_base

Since commit 337cbeb2c13e ("genirq/irq_sim: Simplify the API"),
irq_sim_work_ctx::irq_base is unused. Drop it.

Found by https://github.com/jirislaby/clang-struct.

Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Link: https://lore.kernel.org/all/20240808104118.430670-1-jirislaby@kernel.org

---
 kernel/irq/irq_sim.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/irq/irq_sim.c b/kernel/irq/irq_sim.c
index 3d4036d..1a3d483 100644
--- a/kernel/irq/irq_sim.c
+++ b/kernel/irq/irq_sim.c
@@ -13,7 +13,6 @@
 
 struct irq_sim_work_ctx {
 	struct irq_work		work;
-	int			irq_base;
 	unsigned int		irq_count;
 	unsigned long		*pending;
 	struct irq_domain	*domain;