* [PATCH] staging: drivers: gpu: drm: mediatek: Fix warning: Using plain integer as NULL pointer in mtk_drm_gem.c
@ 2024-08-10 11:07 Dipendra Khadka
2024-08-21 2:14 ` CK Hu (胡俊光)
0 siblings, 1 reply; 2+ messages in thread
From: Dipendra Khadka @ 2024-08-10 11:07 UTC (permalink / raw)
To: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg
Cc: Dipendra Khadka, dri-devel, linux-arm-kernel, linux-mediatek,
linux-kernel
sparse reported following warking:
'''
drivers/gpu/drm/mediatek/mtk_drm_gem.c:290:27: warning: Using plain integer as NULL pointer
'''
This patch changes integer 0 to NULL.
Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com>
---
drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
index f8fd8b98c30e..885ce6ac7bad 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
@@ -287,6 +287,6 @@ void mtk_drm_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr)
return;
vunmap(vaddr);
- mtk_gem->kvaddr = 0;
+ mtk_gem->kvaddr = NULL;
kfree(mtk_gem->pages);
}
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: drivers: gpu: drm: mediatek: Fix warning: Using plain integer as NULL pointer in mtk_drm_gem.c
2024-08-10 11:07 [PATCH] staging: drivers: gpu: drm: mediatek: Fix warning: Using plain integer as NULL pointer in mtk_drm_gem.c Dipendra Khadka
@ 2024-08-21 2:14 ` CK Hu (胡俊光)
0 siblings, 0 replies; 2+ messages in thread
From: CK Hu (胡俊光) @ 2024-08-21 2:14 UTC (permalink / raw)
To: p.zabel, daniel, matthias.bgg, chunkuang.hu, kdipendra88, airlied
Cc: dri-devel, linux-arm-kernel, linux-mediatek, linux-kernel
Hi, Dipendra:
On Sat, 2024-08-10 at 11:07 +0000, Dipendra Khadka wrote:
>
> External email : Please do not click links or open attachments until you have verified the sender or the content.
> sparse reported following warking:
>
> '''
> drivers/gpu/drm/mediatek/mtk_drm_gem.c:290:27: warning: Using plain integer as NULL pointer
> '''
>
> This patch changes integer 0 to NULL.
In latest kernel [1], this has been fixed.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/mediatek/mtk_gem.c?h=v6.11-rc4#n286
And it's fixed in last year. So remember to send patch based on latest kernel.
Regards,
CK
>
> Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_gem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_gem.c b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> index f8fd8b98c30e..885ce6ac7bad 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_gem.c
> @@ -287,6 +287,6 @@ void mtk_drm_gem_prime_vunmap(struct drm_gem_object *obj, void *vaddr)
> return;
>
> vunmap(vaddr);
> - mtk_gem->kvaddr = 0;
> + mtk_gem->kvaddr = NULL;
> kfree(mtk_gem->pages);
> }
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-21 2:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-10 11:07 [PATCH] staging: drivers: gpu: drm: mediatek: Fix warning: Using plain integer as NULL pointer in mtk_drm_gem.c Dipendra Khadka
2024-08-21 2:14 ` CK Hu (胡俊光)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®