* Re: [PATCH net-next 3/3] net: ag71xx: use devm for register_netdev
@ 2024-08-13 6:17 Ratheesh Kannoth
2024-08-13 6:32 ` Rosen Penev
0 siblings, 1 reply; 4+ messages in thread
From: Ratheesh Kannoth @ 2024-08-13 6:17 UTC (permalink / raw)
To: Rosen Penev
Cc: netdev, davem, edumazet, kuba, pabeni, linux, linux-kernel, o.rempel
On 2024-08-13 at 00:36:53, Rosen Penev (rosenp@gmail.com) wrote:
>
> - err = register_netdev(ndev);
> + err = devm_register_netdev(ndev);
devm_register_netdev() needs two arguments.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next 3/3] net: ag71xx: use devm for register_netdev
2024-08-13 6:17 [PATCH net-next 3/3] net: ag71xx: use devm for register_netdev Ratheesh Kannoth
@ 2024-08-13 6:32 ` Rosen Penev
0 siblings, 0 replies; 4+ messages in thread
From: Rosen Penev @ 2024-08-13 6:32 UTC (permalink / raw)
To: Ratheesh Kannoth
Cc: netdev, davem, edumazet, kuba, pabeni, linux, linux-kernel, o.rempel
On Mon, Aug 12, 2024 at 11:17 PM Ratheesh Kannoth <rkannoth@marvell.com> wrote:
>
> On 2024-08-13 at 00:36:53, Rosen Penev (rosenp@gmail.com) wrote:
> >
> > - err = register_netdev(ndev);
> > + err = devm_register_netdev(ndev);
> devm_register_netdev() needs two arguments.
Rebasing error. Will be fixed in v2.
>
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH net-next 0/3] use more devm
@ 2024-08-12 19:06 Rosen Penev
2024-08-12 19:06 ` [PATCH net-next 3/3] net: ag71xx: use devm for register_netdev Rosen Penev
0 siblings, 1 reply; 4+ messages in thread
From: Rosen Penev @ 2024-08-12 19:06 UTC (permalink / raw)
To: netdev; +Cc: davem, edumazet, kuba, pabeni, linux, linux-kernel, o.rempel
Some of these were introduced after the driver got introduced. In any
case, using more devm allows removal of the remove function and overall
simplifies the code. All of these were tested on a TP-LINK Archer C7v2.
Rosen Penev (3):
net: ag71xx: use devm_clk_get_enabled
net: ag71xx: use devm for of_mdiobus_register
net: ag71xx: use devm for register_netdev
drivers/net/ethernet/atheros/ag71xx.c | 84 ++++++---------------------
1 file changed, 19 insertions(+), 65 deletions(-)
--
2.46.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH net-next 3/3] net: ag71xx: use devm for register_netdev
2024-08-12 19:06 [PATCH net-next 0/3] use more devm Rosen Penev
@ 2024-08-12 19:06 ` Rosen Penev
2024-08-12 20:49 ` Daniel Golle
0 siblings, 1 reply; 4+ messages in thread
From: Rosen Penev @ 2024-08-12 19:06 UTC (permalink / raw)
To: netdev; +Cc: davem, edumazet, kuba, pabeni, linux, linux-kernel, o.rempel
Allows completely removing the remove function. Nothing is being done
manually now.
Tested on TP-LINK Archer C7v2.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/net/ethernet/atheros/ag71xx.c | 14 +-------------
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c
index 1bc882fc1388..43f0e2cf987f 100644
--- a/drivers/net/ethernet/atheros/ag71xx.c
+++ b/drivers/net/ethernet/atheros/ag71xx.c
@@ -1923,7 +1923,7 @@ static int ag71xx_probe(struct platform_device *pdev)
return err;
}
- err = register_netdev(ndev);
+ err = devm_register_netdev(ndev);
if (err) {
netif_err(ag, probe, ndev, "unable to register net device\n");
platform_set_drvdata(pdev, NULL);
@@ -1937,17 +1937,6 @@ static int ag71xx_probe(struct platform_device *pdev)
return 0;
}
-static void ag71xx_remove(struct platform_device *pdev)
-{
- struct net_device *ndev = platform_get_drvdata(pdev);
-
- if (!ndev)
- return;
-
- unregister_netdev(ndev);
- platform_set_drvdata(pdev, NULL);
-}
-
static const u32 ar71xx_fifo_ar7100[] = {
0x0fff0000, 0x00001fff, 0x00780fff,
};
@@ -2032,7 +2021,6 @@ static const struct of_device_id ag71xx_match[] = {
static struct platform_driver ag71xx_driver = {
.probe = ag71xx_probe,
- .remove_new = ag71xx_remove,
.driver = {
.name = "ag71xx",
.of_match_table = ag71xx_match,
--
2.46.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next 3/3] net: ag71xx: use devm for register_netdev
2024-08-12 19:06 ` [PATCH net-next 3/3] net: ag71xx: use devm for register_netdev Rosen Penev
@ 2024-08-12 20:49 ` Daniel Golle
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Golle @ 2024-08-12 20:49 UTC (permalink / raw)
To: Rosen Penev
Cc: netdev, davem, edumazet, kuba, pabeni, linux, linux-kernel, o.rempel
On Mon, Aug 12, 2024 at 12:06:53PM -0700, Rosen Penev wrote:
> Allows completely removing the remove function. Nothing is being done
> manually now.
>
> Tested on TP-LINK Archer C7v2.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Daniel Golle <daniel@makrotopia.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-08-13 6:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-13 6:17 [PATCH net-next 3/3] net: ag71xx: use devm for register_netdev Ratheesh Kannoth
2024-08-13 6:32 ` Rosen Penev
-- strict thread matches above, loose matches on Subject: below --
2024-08-12 19:06 [PATCH net-next 0/3] use more devm Rosen Penev
2024-08-12 19:06 ` [PATCH net-next 3/3] net: ag71xx: use devm for register_netdev Rosen Penev
2024-08-12 20:49 ` Daniel Golle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®