From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: bajing <bajing@cmss.chinamobile.com>
Cc: w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca,
speakup@linux-speakup.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] speakup: genmap: remove redundant post-increment
Date: Tue, 13 Aug 2024 09:08:28 +0200 [thread overview]
Message-ID: <20240813070828.65yluzkszaurva5f@begin> (raw)
In-Reply-To: <20240813031753.5902-1-bajing@cmss.chinamobile.com>
bajing, le mar. 13 août 2024 11:17:53 +0800, a ecrit:
> In the while loop, the variable lc is unused and is reinitialized later, so this redundant operation should be removed.
>
> Signed-off-by: bajing <bajing@cmss.chinamobile.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> drivers/accessibility/speakup/genmap.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/accessibility/speakup/genmap.c b/drivers/accessibility/speakup/genmap.c
> index 0125000e00d9..836276327bdd 100644
> --- a/drivers/accessibility/speakup/genmap.c
> +++ b/drivers/accessibility/speakup/genmap.c
> @@ -72,7 +72,6 @@ main(int argc, char *argv[])
>
> open_input(NULL, argv[1]);
> while (fgets(buffer, sizeof(buffer), infile)) {
> - lc++;
> value = shift_state = 0;
>
> cp = strtok(buffer, delims);
> --
> 2.33.0
prev parent reply other threads:[~2024-08-13 7:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 3:17 bajing
2024-08-13 7:08 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240813070828.65yluzkszaurva5f@begin \
--to=samuel.thibault@ens-lyon.org \
--cc=bajing@cmss.chinamobile.com \
--cc=chris@the-brannons.com \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=speakup@linux-speakup.org \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®