* [PATCH] speakup: genmap: remove redundant post-increment
@ 2024-08-13 3:17 bajing
2024-08-13 7:08 ` Samuel Thibault
0 siblings, 1 reply; 2+ messages in thread
From: bajing @ 2024-08-13 3:17 UTC (permalink / raw)
To: w.d.hubbs; +Cc: chris, kirk, samuel.thibault, bajing, speakup, linux-kernel
In the while loop, the variable lc is unused and is reinitialized later, so this redundant operation should be removed.
Signed-off-by: bajing <bajing@cmss.chinamobile.com>
---
drivers/accessibility/speakup/genmap.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/accessibility/speakup/genmap.c b/drivers/accessibility/speakup/genmap.c
index 0125000e00d9..836276327bdd 100644
--- a/drivers/accessibility/speakup/genmap.c
+++ b/drivers/accessibility/speakup/genmap.c
@@ -72,7 +72,6 @@ main(int argc, char *argv[])
open_input(NULL, argv[1]);
while (fgets(buffer, sizeof(buffer), infile)) {
- lc++;
value = shift_state = 0;
cp = strtok(buffer, delims);
--
2.33.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] speakup: genmap: remove redundant post-increment
2024-08-13 3:17 [PATCH] speakup: genmap: remove redundant post-increment bajing
@ 2024-08-13 7:08 ` Samuel Thibault
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Thibault @ 2024-08-13 7:08 UTC (permalink / raw)
To: bajing; +Cc: w.d.hubbs, chris, kirk, speakup, linux-kernel
bajing, le mar. 13 août 2024 11:17:53 +0800, a ecrit:
> In the while loop, the variable lc is unused and is reinitialized later, so this redundant operation should be removed.
>
> Signed-off-by: bajing <bajing@cmss.chinamobile.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> drivers/accessibility/speakup/genmap.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/accessibility/speakup/genmap.c b/drivers/accessibility/speakup/genmap.c
> index 0125000e00d9..836276327bdd 100644
> --- a/drivers/accessibility/speakup/genmap.c
> +++ b/drivers/accessibility/speakup/genmap.c
> @@ -72,7 +72,6 @@ main(int argc, char *argv[])
>
> open_input(NULL, argv[1]);
> while (fgets(buffer, sizeof(buffer), infile)) {
> - lc++;
> value = shift_state = 0;
>
> cp = strtok(buffer, delims);
> --
> 2.33.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-13 7:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-13 3:17 [PATCH] speakup: genmap: remove redundant post-increment bajing
2024-08-13 7:08 ` Samuel Thibault
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®