From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: bajing <bajing@cmss.chinamobile.com>
Cc: w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca,
speakup@linux-speakup.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] speakup: i18n: modify incorrect comments
Date: Wed, 14 Aug 2024 07:59:55 +0200 [thread overview]
Message-ID: <20240814055955.4mf5idugote3pihu@begin> (raw)
In-Reply-To: <20240814030017.2094-1-bajing@cmss.chinamobile.com>
bajing, le mer. 14 août 2024 11:00:17 +0800, a ecrit:
> Regarding the text part, the comment was written incorrectly, so it needs to be modified.
>
> Signed-off-by: bajing <bajing@cmss.chinamobile.com>
> ---
> drivers/accessibility/speakup/i18n.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accessibility/speakup/i18n.c b/drivers/accessibility/speakup/i18n.c
> index d62079b1661f..10c7cdc685f7 100644
> --- a/drivers/accessibility/speakup/i18n.c
> +++ b/drivers/accessibility/speakup/i18n.c
> @@ -541,7 +541,7 @@ static bool fmt_validate(char *template, char *user)
> * If the function fails, then user_messages is untouched.
> * Arguments:
> * - index: a message number, as found in i18n.h.
> - * - text: text of message. Not NUL-terminated.
> + * - text: text of message. Not NULL-terminated.
? Man ascii says it's called NUL, not NULL. We don't want people to
confuse it with the NULL pointer anyway, so no, we don't to change this.
Samuel
> * - length: number of bytes in text.
> * Failure conditions:
> * -EINVAL - Invalid format specifiers in formatted message or illegal index.
> --
> 2.33.0
prev parent reply other threads:[~2024-08-14 6:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 3:00 bajing
2024-08-14 5:59 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240814055955.4mf5idugote3pihu@begin \
--to=samuel.thibault@ens-lyon.org \
--cc=bajing@cmss.chinamobile.com \
--cc=chris@the-brannons.com \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=speakup@linux-speakup.org \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®