* [PATCH] speakup: i18n: modify incorrect comments
@ 2024-08-14 3:00 bajing
2024-08-14 5:59 ` Samuel Thibault
0 siblings, 1 reply; 2+ messages in thread
From: bajing @ 2024-08-14 3:00 UTC (permalink / raw)
To: w.d.hubbs; +Cc: chris, kirk, samuel.thibault, speakup, linux-kernel, bajing
Regarding the text part, the comment was written incorrectly, so it needs to be modified.
Signed-off-by: bajing <bajing@cmss.chinamobile.com>
---
drivers/accessibility/speakup/i18n.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/accessibility/speakup/i18n.c b/drivers/accessibility/speakup/i18n.c
index d62079b1661f..10c7cdc685f7 100644
--- a/drivers/accessibility/speakup/i18n.c
+++ b/drivers/accessibility/speakup/i18n.c
@@ -541,7 +541,7 @@ static bool fmt_validate(char *template, char *user)
* If the function fails, then user_messages is untouched.
* Arguments:
* - index: a message number, as found in i18n.h.
- * - text: text of message. Not NUL-terminated.
+ * - text: text of message. Not NULL-terminated.
* - length: number of bytes in text.
* Failure conditions:
* -EINVAL - Invalid format specifiers in formatted message or illegal index.
--
2.33.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] speakup: i18n: modify incorrect comments
2024-08-14 3:00 [PATCH] speakup: i18n: modify incorrect comments bajing
@ 2024-08-14 5:59 ` Samuel Thibault
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Thibault @ 2024-08-14 5:59 UTC (permalink / raw)
To: bajing; +Cc: w.d.hubbs, chris, kirk, speakup, linux-kernel
bajing, le mer. 14 août 2024 11:00:17 +0800, a ecrit:
> Regarding the text part, the comment was written incorrectly, so it needs to be modified.
>
> Signed-off-by: bajing <bajing@cmss.chinamobile.com>
> ---
> drivers/accessibility/speakup/i18n.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/accessibility/speakup/i18n.c b/drivers/accessibility/speakup/i18n.c
> index d62079b1661f..10c7cdc685f7 100644
> --- a/drivers/accessibility/speakup/i18n.c
> +++ b/drivers/accessibility/speakup/i18n.c
> @@ -541,7 +541,7 @@ static bool fmt_validate(char *template, char *user)
> * If the function fails, then user_messages is untouched.
> * Arguments:
> * - index: a message number, as found in i18n.h.
> - * - text: text of message. Not NUL-terminated.
> + * - text: text of message. Not NULL-terminated.
? Man ascii says it's called NUL, not NULL. We don't want people to
confuse it with the NULL pointer anyway, so no, we don't to change this.
Samuel
> * - length: number of bytes in text.
> * Failure conditions:
> * -EINVAL - Invalid format specifiers in formatted message or illegal index.
> --
> 2.33.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-14 6:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-14 3:00 [PATCH] speakup: i18n: modify incorrect comments bajing
2024-08-14 5:59 ` Samuel Thibault
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®