mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 1/2] usb: dwc3: omap: add missing depopulate in probe error path
@ 2024-08-14 10:18 Krzysztof Kozlowski
  2024-08-14 10:18 ` [PATCH 2/2] usb: dwc3: xilinx: " Krzysztof Kozlowski
  2024-08-14 23:22 ` [PATCH 1/2] usb: dwc3: omap: " Thinh Nguyen
  0 siblings, 2 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-14 10:18 UTC (permalink / raw)
  To: Thinh Nguyen, Greg Kroah-Hartman, Michal Simek,
	Grygorii Strashko, Vignesh R, Felipe Balbi, Radhey Shyam Pandey,
	Piyush Mehta, linux-usb, linux-omap, linux-kernel,
	linux-arm-kernel
  Cc: Krzysztof Kozlowski, stable

Depopulate device in probe error paths to fix leak of children
resources.

Fixes: ee249b455494 ("usb: dwc3: omap: remove IRQ_NOAUTOEN used with shared irq")
Cc: <stable@vger.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/usb/dwc3/dwc3-omap.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
index d5c77db4daa9..2a11fc0ee84f 100644
--- a/drivers/usb/dwc3/dwc3-omap.c
+++ b/drivers/usb/dwc3/dwc3-omap.c
@@ -522,11 +522,13 @@ static int dwc3_omap_probe(struct platform_device *pdev)
 	if (ret) {
 		dev_err(dev, "failed to request IRQ #%d --> %d\n",
 			omap->irq, ret);
-		goto err1;
+		goto err2;
 	}
 	dwc3_omap_enable_irqs(omap);
 	return 0;
 
+err2:
+	of_platform_depopulate(dev);
 err1:
 	pm_runtime_put_sync(dev);
 	pm_runtime_disable(dev);
-- 
2.43.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-08-16  5:31 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-14 10:18 [PATCH 1/2] usb: dwc3: omap: add missing depopulate in probe error path Krzysztof Kozlowski
2024-08-14 10:18 ` [PATCH 2/2] usb: dwc3: xilinx: " Krzysztof Kozlowski
2024-08-14 10:31   ` Pandey, Radhey Shyam
2024-08-14 23:31   ` Thinh Nguyen
2024-08-16  5:30     ` Krzysztof Kozlowski
2024-08-14 23:22 ` [PATCH 1/2] usb: dwc3: omap: " Thinh Nguyen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®