mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 1/1] EDAC/igen6: Fix conversion of system address to physical memory address
@ 2024-08-14  6:10 Qiuxu Zhuo
  2024-08-14  6:32 ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Qiuxu Zhuo @ 2024-08-14  6:10 UTC (permalink / raw)
  To: Tony Luck
  Cc: Qiuxu Zhuo, Borislav Petkov, James Morse, Mauro Carvalho Chehab,
	Robert Richter, linux-edac, linux-kernel, stable

The conversion of system address to physical memory address (as viewed by
the memory controller) by igen6_edac is incorrect when the system address
is above the TOM (Total amount Of populated physical Memory) for Elkhart
Lake and Ice Lake (Neural Network Processor). Fix this conversion.

Fixes: 10590a9d4f23 ("EDAC/igen6: Add EDAC driver for Intel client SoCs using IBECC")
Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
---
 drivers/edac/igen6_edac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/edac/igen6_edac.c b/drivers/edac/igen6_edac.c
index 0fe75eed8973..189a2fc29e74 100644
--- a/drivers/edac/igen6_edac.c
+++ b/drivers/edac/igen6_edac.c
@@ -316,7 +316,7 @@ static u64 ehl_err_addr_to_imc_addr(u64 eaddr, int mc)
 	if (igen6_tom <= _4GB)
 		return eaddr + igen6_tolud - _4GB;
 
-	if (eaddr < _4GB)
+	if (eaddr >= igen6_tom)
 		return eaddr + igen6_tolud - igen6_tom;
 
 	return eaddr;
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] EDAC/igen6: Fix conversion of system address to physical memory address
  2024-08-14  6:10 [PATCH 1/1] EDAC/igen6: Fix conversion of system address to physical memory address Qiuxu Zhuo
@ 2024-08-14  6:32 ` Greg KH
  2024-08-14 12:58   ` Zhuo, Qiuxu
  0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2024-08-14  6:32 UTC (permalink / raw)
  To: Qiuxu Zhuo
  Cc: Tony Luck, Borislav Petkov, James Morse, Mauro Carvalho Chehab,
	Robert Richter, linux-edac, linux-kernel, stable

On Wed, Aug 14, 2024 at 02:10:11PM +0800, Qiuxu Zhuo wrote:
> The conversion of system address to physical memory address (as viewed by
> the memory controller) by igen6_edac is incorrect when the system address
> is above the TOM (Total amount Of populated physical Memory) for Elkhart
> Lake and Ice Lake (Neural Network Processor). Fix this conversion.
> 
> Fixes: 10590a9d4f23 ("EDAC/igen6: Add EDAC driver for Intel client SoCs using IBECC")
> Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
> ---
>  drivers/edac/igen6_edac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/edac/igen6_edac.c b/drivers/edac/igen6_edac.c
> index 0fe75eed8973..189a2fc29e74 100644
> --- a/drivers/edac/igen6_edac.c
> +++ b/drivers/edac/igen6_edac.c
> @@ -316,7 +316,7 @@ static u64 ehl_err_addr_to_imc_addr(u64 eaddr, int mc)
>  	if (igen6_tom <= _4GB)
>  		return eaddr + igen6_tolud - _4GB;
>  
> -	if (eaddr < _4GB)
> +	if (eaddr >= igen6_tom)
>  		return eaddr + igen6_tolud - igen6_tom;
>  
>  	return eaddr;
> -- 
> 2.17.1
> 
> 

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH 1/1] EDAC/igen6: Fix conversion of system address to physical memory address
  2024-08-14  6:32 ` Greg KH
@ 2024-08-14 12:58   ` Zhuo, Qiuxu
  0 siblings, 0 replies; 3+ messages in thread
From: Zhuo, Qiuxu @ 2024-08-14 12:58 UTC (permalink / raw)
  To: Greg KH
  Cc: Luck, Tony, Borislav Petkov, James Morse, Mauro Carvalho Chehab,
	Robert Richter, linux-edac, linux-kernel

Hi Greg,

> From: Greg KH <gregkh@linuxfoundation.org>
> [...]
> 
> This is not the correct way to submit patches for inclusion in the stable kernel
> tree.  Please read:
>     https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly.

Thank you for the reminder. I read the link above.
To avoid making the same mistake next time 😊, could you confirm if this is because
the patch does not meet the following conditions:

   " It or an equivalent fix must already exist in Linux mainline (upstream)."

Thanks!
-Qiuxu

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-08-14 12:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-14  6:10 [PATCH 1/1] EDAC/igen6: Fix conversion of system address to physical memory address Qiuxu Zhuo
2024-08-14  6:32 ` Greg KH
2024-08-14 12:58   ` Zhuo, Qiuxu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®