From: Alexander Dahl <ada@thorsis.com>
To: Andrei Simion <andrei.simion@microchip.com>
Cc: claudiu.beznea@tuxon.dev, nicolas.ferre@microchip.com,
alexandre.belloni@bootlin.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, peda@axentia.se,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
cristian.birsan@microchip.com, linux-leds@vger.kernel.org
Subject: Re: [PATCH 5/5] ARM: dts: microchip: Rename LED sub nodes name
Date: Thu, 15 Aug 2024 09:57:56 +0200 [thread overview]
Message-ID: <20240815-ambush-cavalier-80adf0260765@thorsis.com> (raw)
In-Reply-To: <20240814122633.198562-6-andrei.simion@microchip.com>
Hello Andrei,
Am Wed, Aug 14, 2024 at 03:26:33PM +0300 schrieb Andrei Simion:
> dtbs_check warnings:
> leds: 'd[0-9]', 'ds[0-9]' do not match any of the regexes:
> '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
> leds: 'red', 'green', 'blue' do not match any of regexes:
> '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
>
> Rename the led sub nodes according to devicetree
> specification and leds-gpio.yaml.
>
> Signed-off-by: Andrei Simion <andrei.simion@microchip.com>
> ---
> Split the bloadted patch into small patches on topics
> based on comments:
> https://lore.kernel.org/linux-arm-kernel/89f51615-0dee-4ab0-ab72-e3c057fee1e7@tuxon.dev/
> ---
> arch/arm/boot/dts/microchip/aks-cdu.dts | 8 ++++----
> arch/arm/boot/dts/microchip/animeo_ip.dts | 8 ++++----
> arch/arm/boot/dts/microchip/at91-sam9x60ek.dts | 6 +++---
> arch/arm/boot/dts/microchip/at91rm9200ek.dts | 6 +++---
> arch/arm/boot/dts/microchip/at91sam9260ek.dts | 4 ++--
> arch/arm/boot/dts/microchip/at91sam9261ek.dts | 6 +++---
> arch/arm/boot/dts/microchip/at91sam9263ek.dts | 4 ++--
> arch/arm/boot/dts/microchip/at91sam9g20ek.dts | 4 ++--
> 8 files changed, 23 insertions(+), 23 deletions(-)
>
> diff --git a/arch/arm/boot/dts/microchip/aks-cdu.dts b/arch/arm/boot/dts/microchip/aks-cdu.dts
> index 52e166c8a365..95a0639c5579 100644
> --- a/arch/arm/boot/dts/microchip/aks-cdu.dts
> +++ b/arch/arm/boot/dts/microchip/aks-cdu.dts
> @@ -98,23 +98,23 @@ rootfs@500000 {
> leds {
> compatible = "gpio-leds";
>
> - red {
> + led-red {
> gpios = <&pioC 10 GPIO_ACTIVE_HIGH>;
> linux,default-trigger = "none";
> };
>
> - green {
> + led-green {
> gpios = <&pioA 5 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "none";
> default-state = "on";
> };
>
> - yellow {
> + led-yellow {
> gpios = <&pioB 20 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "none";
> };
>
> - blue {
> + led-blue {
> gpios = <&pioB 21 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "none";
> };
As reported with <20240730-rambling-helping-2f03f5ddee6a@thorsis.com>
already, this will probably change sysfs paths and thus might break
userspace depending on those paths. Did you consider adding a label
to avoid this?
(Added linux-leds to Cc.)
Greets
Alex
> diff --git a/arch/arm/boot/dts/microchip/animeo_ip.dts b/arch/arm/boot/dts/microchip/animeo_ip.dts
> index 911c8d9ee013..52ac840bcd35 100644
> --- a/arch/arm/boot/dts/microchip/animeo_ip.dts
> +++ b/arch/arm/boot/dts/microchip/animeo_ip.dts
> @@ -146,23 +146,23 @@ ohci: usb@500000 {
> leds {
> compatible = "gpio-leds";
>
> - power_green {
> + led-power-green {
> label = "power_green";
> gpios = <&pioC 17 GPIO_ACTIVE_HIGH>;
> linux,default-trigger = "heartbeat";
> };
>
> - power_red {
> + led-power-red {
> label = "power_red";
> gpios = <&pioA 2 GPIO_ACTIVE_HIGH>;
> };
>
> - tx_green {
> + led-tx-green {
> label = "tx_green";
> gpios = <&pioC 19 GPIO_ACTIVE_HIGH>;
> };
>
> - tx_red {
> + led-tx-red {
> label = "tx_red";
> gpios = <&pioC 18 GPIO_ACTIVE_HIGH>;
> };
> diff --git a/arch/arm/boot/dts/microchip/at91-sam9x60ek.dts b/arch/arm/boot/dts/microchip/at91-sam9x60ek.dts
> index b9a21f9f9a6d..da31b07d6828 100644
> --- a/arch/arm/boot/dts/microchip/at91-sam9x60ek.dts
> +++ b/arch/arm/boot/dts/microchip/at91-sam9x60ek.dts
> @@ -53,17 +53,17 @@ leds {
> pinctrl-0 = <&pinctrl_gpio_leds>;
> status = "okay"; /* Conflict with pwm0. */
>
> - red {
> + led-red {
> label = "red";
> gpios = <&pioB 11 GPIO_ACTIVE_HIGH>;
> };
>
> - green {
> + led-green {
> label = "green";
> gpios = <&pioB 12 GPIO_ACTIVE_HIGH>;
> };
>
> - blue {
> + led-blue {
> label = "blue";
> gpios = <&pioB 13 GPIO_ACTIVE_HIGH>;
> linux,default-trigger = "heartbeat";
> diff --git a/arch/arm/boot/dts/microchip/at91rm9200ek.dts b/arch/arm/boot/dts/microchip/at91rm9200ek.dts
> index 3089912dd6be..641d443e6ca9 100644
> --- a/arch/arm/boot/dts/microchip/at91rm9200ek.dts
> +++ b/arch/arm/boot/dts/microchip/at91rm9200ek.dts
> @@ -127,19 +127,19 @@ root@350000 {
> leds {
> compatible = "gpio-leds";
>
> - ds2 {
> + led-ds2 {
> label = "green";
> gpios = <&pioB 0 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "mmc0";
> };
>
> - ds4 {
> + led-ds4 {
> label = "yellow";
> gpios = <&pioB 1 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "heartbeat";
> };
>
> - ds6 {
> + led-ds6 {
> label = "red";
> gpios = <&pioB 2 GPIO_ACTIVE_LOW>;
> };
> diff --git a/arch/arm/boot/dts/microchip/at91sam9260ek.dts b/arch/arm/boot/dts/microchip/at91sam9260ek.dts
> index ed259e2cb853..4933971d0585 100644
> --- a/arch/arm/boot/dts/microchip/at91sam9260ek.dts
> +++ b/arch/arm/boot/dts/microchip/at91sam9260ek.dts
> @@ -174,13 +174,13 @@ eeprom@50 {
> leds {
> compatible = "gpio-leds";
>
> - ds1 {
> + led-ds1 {
> label = "ds1";
> gpios = <&pioA 9 GPIO_ACTIVE_HIGH>;
> linux,default-trigger = "heartbeat";
> };
>
> - ds5 {
> + led-ds5 {
> label = "ds5";
> gpios = <&pioA 6 GPIO_ACTIVE_LOW>;
> };
> diff --git a/arch/arm/boot/dts/microchip/at91sam9261ek.dts b/arch/arm/boot/dts/microchip/at91sam9261ek.dts
> index 4d9269cc5f32..9c44177db714 100644
> --- a/arch/arm/boot/dts/microchip/at91sam9261ek.dts
> +++ b/arch/arm/boot/dts/microchip/at91sam9261ek.dts
> @@ -192,19 +192,19 @@ watchdog@fffffd40 {
> leds {
> compatible = "gpio-leds";
>
> - ds8 {
> + led-ds8 {
> label = "ds8";
> gpios = <&pioA 13 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "none";
> };
>
> - ds7 {
> + led-ds7 {
> label = "ds7";
> gpios = <&pioA 14 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "nand-disk";
> };
>
> - ds1 {
> + led-ds1 {
> label = "ds1";
> gpios = <&pioA 23 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "heartbeat";
> diff --git a/arch/arm/boot/dts/microchip/at91sam9263ek.dts b/arch/arm/boot/dts/microchip/at91sam9263ek.dts
> index a8ea36db4c04..cf5434f9449d 100644
> --- a/arch/arm/boot/dts/microchip/at91sam9263ek.dts
> +++ b/arch/arm/boot/dts/microchip/at91sam9263ek.dts
> @@ -219,13 +219,13 @@ &pioA 21 GPIO_ACTIVE_HIGH
> leds {
> compatible = "gpio-leds";
>
> - d3 {
> + led-d3 {
> label = "d3";
> gpios = <&pioB 7 GPIO_ACTIVE_HIGH>;
> linux,default-trigger = "heartbeat";
> };
>
> - d2 {
> + led-d2 {
> label = "d2";
> gpios = <&pioC 29 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "nand-disk";
> diff --git a/arch/arm/boot/dts/microchip/at91sam9g20ek.dts b/arch/arm/boot/dts/microchip/at91sam9g20ek.dts
> index 6de7a7cd3c07..1e62fd371ddb 100644
> --- a/arch/arm/boot/dts/microchip/at91sam9g20ek.dts
> +++ b/arch/arm/boot/dts/microchip/at91sam9g20ek.dts
> @@ -14,13 +14,13 @@ / {
> leds {
> compatible = "gpio-leds";
>
> - ds1 {
> + led-ds1 {
> label = "ds1";
> gpios = <&pioA 9 GPIO_ACTIVE_HIGH>;
> linux,default-trigger = "heartbeat";
> };
>
> - ds5 {
> + led-ds5 {
> label = "ds5";
> gpios = <&pioA 6 GPIO_ACTIVE_LOW>;
> };
> --
> 2.34.1
>
>
next prev parent reply other threads:[~2024-08-15 7:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 12:26 [PATCH 0/5] Cosmetic Work for ARM/Microchip (AT91) Andrei Simion
2024-08-14 12:26 ` [PATCH 1/5] ARM: dts: microchip: Clean up spacing and indentation Andrei Simion
2024-08-14 13:20 ` Krzysztof Kozlowski
2024-08-14 13:32 ` Andrei.Simion
2024-08-14 13:57 ` Krzysztof Kozlowski
2024-08-14 14:20 ` Andrei.Simion
2024-08-14 12:26 ` [PATCH 2/5] ARM: dts: microchip: Rename the eeprom nodename Andrei Simion
2024-08-14 12:26 ` [PATCH 3/5] ARM: dts: microchip: Rename the pmic node Andrei Simion
2024-08-14 13:20 ` Krzysztof Kozlowski
2024-08-14 13:58 ` Krzysztof Kozlowski
2024-08-14 12:26 ` [PATCH 4/5] ARM: dts: microchip: Rename the usb node Andrei Simion
2024-08-14 13:22 ` Krzysztof Kozlowski
2024-09-05 13:51 ` Andrei.Simion
2024-09-05 13:55 ` Krzysztof Kozlowski
2024-08-14 12:26 ` [PATCH 5/5] ARM: dts: microchip: Rename LED sub nodes name Andrei Simion
2024-08-14 13:23 ` Krzysztof Kozlowski
2024-08-15 7:57 ` Alexander Dahl [this message]
2024-08-16 8:52 ` Andrei.Simion
2024-08-16 9:06 ` Alexander Dahl
2024-08-20 6:32 ` Andrei.Simion
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240815-ambush-cavalier-80adf0260765@thorsis.com \
--to=ada@thorsis.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrei.simion@microchip.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=cristian.birsan@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=peda@axentia.se \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®