From: Ivan Orlov <ivan.orlov0322@gmail.com>
To: akpm@linux-foundation.org, kees@kernel.org, davidgow@google.com
Cc: Ivan Orlov <ivan.orlov0322@gmail.com>,
kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org,
erhard_f@mailbox.org
Subject: [PATCH] kunit/overflow: Fix UB in overflow_allocation_test
Date: Thu, 15 Aug 2024 01:04:31 +0100 [thread overview]
Message-ID: <20240815000431.401869-1-ivan.orlov0322@gmail.com> (raw)
The 'device_name' array doesn't exist out of the
'overflow_allocation_test' function scope. However, it is being used as
a driver name when calling 'kunit_driver_create' from
'kunit_device_register'. It produces the kernel panic with KASAN
enabled.
Since this variable is used in one place only, remove it and pass the
device name into kunit_device_register directly as an ascii string.
Signed-off-by: Ivan Orlov <ivan.orlov0322@gmail.com>
---
lib/overflow_kunit.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/overflow_kunit.c b/lib/overflow_kunit.c
index f314a0c15a6d..2abc78367dd1 100644
--- a/lib/overflow_kunit.c
+++ b/lib/overflow_kunit.c
@@ -668,7 +668,6 @@ DEFINE_TEST_ALLOC(devm_kzalloc, devm_kfree, 1, 1, 0);
static void overflow_allocation_test(struct kunit *test)
{
- const char device_name[] = "overflow-test";
struct device *dev;
int count = 0;
@@ -678,7 +677,7 @@ static void overflow_allocation_test(struct kunit *test)
} while (0)
/* Create dummy device for devm_kmalloc()-family tests. */
- dev = kunit_device_register(test, device_name);
+ dev = kunit_device_register(test, "overflow-test");
KUNIT_ASSERT_FALSE_MSG(test, IS_ERR(dev),
"Cannot register test device\n");
--
2.34.1
next reply other threads:[~2024-08-15 0:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 0:04 Ivan Orlov [this message]
2024-08-15 6:30 ` Erhard Furtner
2024-08-15 6:39 ` David Gow
2024-08-15 16:28 ` Kees Cook
2024-08-15 23:01 ` Andrew Morton
2024-08-16 1:22 ` Ivan Orlov
2024-08-16 3:36 ` Kees Cook
2024-08-15 23:04 ` Andrew Morton
2024-08-16 1:27 ` Ivan Orlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240815000431.401869-1-ivan.orlov0322@gmail.com \
--to=ivan.orlov0322@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=davidgow@google.com \
--cc=erhard_f@mailbox.org \
--cc=kees@kernel.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®