From: Kees Cook <kees@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>,
Ivan Orlov <ivan.orlov0322@gmail.com>
Cc: davidgow@google.com, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org, erhard_f@mailbox.org
Subject: Re: [PATCH] kunit/overflow: Fix UB in overflow_allocation_test
Date: Thu, 15 Aug 2024 20:36:49 -0700 [thread overview]
Message-ID: <32F8F341-56C1-4E2A-9227-9909980A153C@kernel.org> (raw)
In-Reply-To: <20240815160148.be83228a7804c6389393429a@linux-foundation.org>
On August 15, 2024 4:01:48 PM PDT, Andrew Morton <akpm@linux-foundation.org> wrote:
>On Thu, 15 Aug 2024 01:04:31 +0100 Ivan Orlov <ivan.orlov0322@gmail.com> wrote:
>
>> The 'device_name' array doesn't exist out of the
>> 'overflow_allocation_test' function scope. However, it is being used as
>> a driver name when calling 'kunit_driver_create' from
>> 'kunit_device_register'. It produces the kernel panic with KASAN
>> enabled.
>>
>> Since this variable is used in one place only, remove it and pass the
>> device name into kunit_device_register directly as an ascii string.
>
>Fixes: ca90800a91ba ("test_overflow: Add memory allocation overflow tests")
>Cc: <stable@vger.kernel.org>
>
>yes?
>
>
>I'll grab it now, but perhaps Kees will handle this.
I already grabbed it:
https://lore.kernel.org/lkml/172373928009.559695.8528767427266408069.b4-ty@kernel.org/
But I'll update the tags. Thanks!
--
Kees Cook
next prev parent reply other threads:[~2024-08-16 3:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 0:04 Ivan Orlov
2024-08-15 6:30 ` Erhard Furtner
2024-08-15 6:39 ` David Gow
2024-08-15 16:28 ` Kees Cook
2024-08-15 23:01 ` Andrew Morton
2024-08-16 1:22 ` Ivan Orlov
2024-08-16 3:36 ` Kees Cook [this message]
2024-08-15 23:04 ` Andrew Morton
2024-08-16 1:27 ` Ivan Orlov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32F8F341-56C1-4E2A-9227-9909980A153C@kernel.org \
--to=kees@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=davidgow@google.com \
--cc=erhard_f@mailbox.org \
--cc=ivan.orlov0322@gmail.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®