From: Jonathan Cameron <jic23@kernel.org>
To: Dumitru Ceclan <mitrutzceclan@gmail.com>
Cc: dlechner@baylibre.com, dumitru.ceclan@analog.com0,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Dumitru Ceclan <dumitru.ceclan@analog.com>
Subject: Re: [PATCH] iio: adc: ad7173: fix GPIO device info
Date: Sat, 17 Aug 2024 11:20:37 +0100 [thread overview]
Message-ID: <20240817112037.68cb99c2@jic23-huawei> (raw)
In-Reply-To: <20240809134909.26829-1-dumitru.ceclan@analog.com>
On Fri, 9 Aug 2024 16:49:08 +0300
Dumitru Ceclan <mitrutzceclan@gmail.com> wrote:
> Models AD4114/5/6 have .higher_gpio_bits = true. This is not correct as
> the only models that have the GPIO bits to a higher position are AD4111/2.
>
> Fix by removing the higher_gpio_bits = true from the AD4114/5/6 models.
>
> Fixes: 13d12e3ad12d ("iio: adc: ad7173: Add support for AD411x devices")
> Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com>
Applied and marked for stable.
Thanks,
Jonathan
> ---
> drivers/iio/adc/ad7173.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
> index 9544bf7142ad..b77e2beb502a 100644
> --- a/drivers/iio/adc/ad7173.c
> +++ b/drivers/iio/adc/ad7173.c
> @@ -302,7 +302,6 @@ static const struct ad7173_device_info ad4114_device_info = {
> .num_configs = 8,
> .num_voltage_in = 16,
> .num_gpios = 4,
> - .higher_gpio_bits = true,
> .has_vincom_input = true,
> .has_temp = true,
> .has_input_buf = true,
> @@ -320,7 +319,6 @@ static const struct ad7173_device_info ad4115_device_info = {
> .num_configs = 8,
> .num_voltage_in = 16,
> .num_gpios = 4,
> - .higher_gpio_bits = true,
> .has_vincom_input = true,
> .has_temp = true,
> .has_input_buf = true,
> @@ -338,7 +336,6 @@ static const struct ad7173_device_info ad4116_device_info = {
> .num_configs = 8,
> .num_voltage_in = 16,
> .num_gpios = 4,
> - .higher_gpio_bits = true,
> .has_vincom_input = true,
> .has_temp = true,
> .has_input_buf = true,
prev parent reply other threads:[~2024-08-17 10:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 13:49 Dumitru Ceclan
2024-08-17 10:20 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240817112037.68cb99c2@jic23-huawei \
--to=jic23@kernel.org \
--cc=dlechner@baylibre.com \
--cc=dumitru.ceclan@analog.com \
--cc=dumitru.ceclan@analog.com0 \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mitrutzceclan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®