* [PATCH] iio: adc: ad7173: fix GPIO device info
@ 2024-08-09 13:49 Dumitru Ceclan
2024-08-17 10:20 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Dumitru Ceclan @ 2024-08-09 13:49 UTC (permalink / raw)
To: mitrutzceclan
Cc: jic23, dlechner, dumitru.ceclan, linux-iio, linux-kernel, Dumitru Ceclan
Models AD4114/5/6 have .higher_gpio_bits = true. This is not correct as
the only models that have the GPIO bits to a higher position are AD4111/2.
Fix by removing the higher_gpio_bits = true from the AD4114/5/6 models.
Fixes: 13d12e3ad12d ("iio: adc: ad7173: Add support for AD411x devices")
Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com>
---
drivers/iio/adc/ad7173.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
index 9544bf7142ad..b77e2beb502a 100644
--- a/drivers/iio/adc/ad7173.c
+++ b/drivers/iio/adc/ad7173.c
@@ -302,7 +302,6 @@ static const struct ad7173_device_info ad4114_device_info = {
.num_configs = 8,
.num_voltage_in = 16,
.num_gpios = 4,
- .higher_gpio_bits = true,
.has_vincom_input = true,
.has_temp = true,
.has_input_buf = true,
@@ -320,7 +319,6 @@ static const struct ad7173_device_info ad4115_device_info = {
.num_configs = 8,
.num_voltage_in = 16,
.num_gpios = 4,
- .higher_gpio_bits = true,
.has_vincom_input = true,
.has_temp = true,
.has_input_buf = true,
@@ -338,7 +336,6 @@ static const struct ad7173_device_info ad4116_device_info = {
.num_configs = 8,
.num_voltage_in = 16,
.num_gpios = 4,
- .higher_gpio_bits = true,
.has_vincom_input = true,
.has_temp = true,
.has_input_buf = true,
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] iio: adc: ad7173: fix GPIO device info
2024-08-09 13:49 [PATCH] iio: adc: ad7173: fix GPIO device info Dumitru Ceclan
@ 2024-08-17 10:20 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2024-08-17 10:20 UTC (permalink / raw)
To: Dumitru Ceclan
Cc: dlechner, dumitru.ceclan, linux-iio, linux-kernel, Dumitru Ceclan
On Fri, 9 Aug 2024 16:49:08 +0300
Dumitru Ceclan <mitrutzceclan@gmail.com> wrote:
> Models AD4114/5/6 have .higher_gpio_bits = true. This is not correct as
> the only models that have the GPIO bits to a higher position are AD4111/2.
>
> Fix by removing the higher_gpio_bits = true from the AD4114/5/6 models.
>
> Fixes: 13d12e3ad12d ("iio: adc: ad7173: Add support for AD411x devices")
> Signed-off-by: Dumitru Ceclan <dumitru.ceclan@analog.com>
Applied and marked for stable.
Thanks,
Jonathan
> ---
> drivers/iio/adc/ad7173.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/iio/adc/ad7173.c b/drivers/iio/adc/ad7173.c
> index 9544bf7142ad..b77e2beb502a 100644
> --- a/drivers/iio/adc/ad7173.c
> +++ b/drivers/iio/adc/ad7173.c
> @@ -302,7 +302,6 @@ static const struct ad7173_device_info ad4114_device_info = {
> .num_configs = 8,
> .num_voltage_in = 16,
> .num_gpios = 4,
> - .higher_gpio_bits = true,
> .has_vincom_input = true,
> .has_temp = true,
> .has_input_buf = true,
> @@ -320,7 +319,6 @@ static const struct ad7173_device_info ad4115_device_info = {
> .num_configs = 8,
> .num_voltage_in = 16,
> .num_gpios = 4,
> - .higher_gpio_bits = true,
> .has_vincom_input = true,
> .has_temp = true,
> .has_input_buf = true,
> @@ -338,7 +336,6 @@ static const struct ad7173_device_info ad4116_device_info = {
> .num_configs = 8,
> .num_voltage_in = 16,
> .num_gpios = 4,
> - .higher_gpio_bits = true,
> .has_vincom_input = true,
> .has_temp = true,
> .has_input_buf = true,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-17 10:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-09 13:49 [PATCH] iio: adc: ad7173: fix GPIO device info Dumitru Ceclan
2024-08-17 10:20 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®