mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mary Guillemard <mary@mary.zone>
To: linux-kernel@vger.kernel.org
Cc: linux-scsi@vger.kernel.org, Mary Guillemard <mary@mary.zone>,
	Peter Wang <peter.wang@mediatek.com>,
	Stanley Jhu <chu.stanley@gmail.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>
Subject: [PATCH 1/1] scsi: ufs-mediatek: Add UFSHCD_QUIRK_BROKEN_LSDBS_CAP
Date: Mon, 19 Aug 2024 00:24:42 +0200	[thread overview]
Message-ID: <20240818222442.44990-3-mary@mary.zone> (raw)
In-Reply-To: <20240818222442.44990-2-mary@mary.zone>

MT8183 supports UFSHCI 2.1 spec, but report a bogus value of 1 in the
reserved part for the Legacy Single Doorbell Support (LSDBS) capability.

This set UFSHCD_QUIRK_BROKEN_LSDBS_CAP when MCQ support is explicitly
disabled, allowing the device to be properly registered.

Signed-off-by: Mary Guillemard <mary@mary.zone>
---
 drivers/ufs/host/ufs-mediatek.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c
index 02c9064284e1..9a5919434c4e 100644
--- a/drivers/ufs/host/ufs-mediatek.c
+++ b/drivers/ufs/host/ufs-mediatek.c
@@ -1026,6 +1026,9 @@ static int ufs_mtk_init(struct ufs_hba *hba)
 	if (host->caps & UFS_MTK_CAP_DISABLE_AH8)
 		hba->caps |= UFSHCD_CAP_HIBERN8_WITH_CLK_GATING;
 
+	if (host->caps & UFS_MTK_CAP_DISABLE_MCQ)
+		hba->quirks |= UFSHCD_QUIRK_BROKEN_LSDBS_CAP;
+
 	ufs_mtk_init_clocks(hba);
 
 	/*
-- 
2.46.0


  reply	other threads:[~2024-08-18 22:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-18 22:24 [PATCH 0/1] ufs: mediatek: Fix probe failure on MT8395 SoC Mary Guillemard
2024-08-18 22:24 ` Mary Guillemard [this message]
2024-08-19 12:08   ` [PATCH 1/1] scsi: ufs-mediatek: Add UFSHCD_QUIRK_BROKEN_LSDBS_CAP Manivannan Sadhasivam
2024-08-19 18:17     ` Mary Guillemard
2024-08-20  5:56       ` Peter Wang (王信友)
2024-08-20  6:09       ` Manivannan Sadhasivam
2024-08-20 21:50         ` Bart Van Assche
2024-08-21 21:32           ` Mary Guillemard
2024-08-22  6:34             ` Manivannan Sadhasivam
2024-08-20  5:58   ` Peter Wang (王信友)
2024-08-29  2:50   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240818222442.44990-3-mary@mary.zone \
    --to=mary@mary.zone \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chu.stanley@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=matthias.bgg@gmail.com \
    --cc=peter.wang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®