From: Cindy Lu <lulu@redhat.com>
To: lulu@redhat.com, jasowang@redhat.com, mst@redhat.com,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: [RFC 3/7] vhost: Add kthread support in function vhost_workers_free()
Date: Mon, 19 Aug 2024 17:27:29 +0800 [thread overview]
Message-ID: <20240819092851.441670-4-lulu@redhat.com> (raw)
In-Reply-To: <20240819092851.441670-1-lulu@redhat.com>
Added back the previously removed function vhost_workers_free() and
renamed it to vhost_workers_free_khtread(). The new vhost_workers_free()
will select the different mode based on the value of the parameter.
Signed-off-by: Cindy Lu <lulu@redhat.com>
---
drivers/vhost/vhost.c | 52 ++++++++++++++++++++++++++++++++++++++-----
1 file changed, 47 insertions(+), 5 deletions(-)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 6261c9df468e..77071def355c 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -647,8 +647,21 @@ static void vhost_detach_mm(struct vhost_dev *dev)
dev->mm = NULL;
}
-static void vhost_worker_destroy(struct vhost_dev *dev,
- struct vhost_worker *worker)
+static void vhost_worker_destroy_kthread(struct vhost_dev *dev,
+ struct vhost_worker *worker)
+{
+ if (!worker)
+ return;
+
+ WARN_ON(!llist_empty(&worker->work_list));
+
+ xa_erase(&dev->worker_xa, worker->id);
+ kthread_stop(worker->task);
+ kfree(worker);
+}
+
+static void vhost_worker_destroy_task(struct vhost_dev *dev,
+ struct vhost_worker *worker)
{
if (!worker)
return;
@@ -659,7 +672,7 @@ static void vhost_worker_destroy(struct vhost_dev *dev,
kfree(worker);
}
-static void vhost_workers_free(struct vhost_dev *dev)
+static void vhost_workers_free_task(struct vhost_dev *dev)
{
struct vhost_worker *worker;
unsigned long i;
@@ -674,10 +687,36 @@ static void vhost_workers_free(struct vhost_dev *dev)
* created but couldn't clean up (it forgot or crashed).
*/
xa_for_each(&dev->worker_xa, i, worker)
- vhost_worker_destroy(dev, worker);
+ vhost_worker_destroy_task(dev, worker);
xa_destroy(&dev->worker_xa);
}
+static void vhost_workers_free_kthread(struct vhost_dev *dev)
+{
+ struct vhost_worker *worker;
+ unsigned long i;
+
+ if (!dev->use_worker)
+ return;
+
+ for (i = 0; i < dev->nvqs; i++)
+ rcu_assign_pointer(dev->vqs[i]->worker, NULL);
+ /*
+ * Free the default worker we created and cleanup workers userspace
+ * created but couldn't clean up (it forgot or crashed).
+ */
+ xa_for_each(&dev->worker_xa, i, worker)
+ vhost_worker_destroy_kthread(dev, worker);
+ xa_destroy(&dev->worker_xa);
+}
+
+static void vhost_workers_free(struct vhost_dev *dev)
+{
+ if (use_kthread)
+ vhost_workers_free_kthread(dev);
+ else
+ vhost_workers_free_task(dev);
+}
static struct vhost_worker *vhost_worker_create(struct vhost_dev *dev)
{
struct vhost_worker *worker;
@@ -845,7 +884,10 @@ static int vhost_free_worker(struct vhost_dev *dev,
__vhost_worker_flush(worker);
mutex_unlock(&worker->mutex);
- vhost_worker_destroy(dev, worker);
+ if (use_kthread)
+ vhost_worker_destroy_kthread(dev, worker);
+ else
+ vhost_worker_destroy_task(dev, worker);
return 0;
}
--
2.45.0
next prev parent reply other threads:[~2024-08-19 9:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 9:27 [RFC 0/7] vhost: Add support of kthread API Cindy Lu
2024-08-19 9:27 ` [RFC 1/7] vhost: Add a new module_param for enable kthread Cindy Lu
2024-08-19 9:27 ` [RFC 2/7] vhost: Add kthread support in function vhost_worker_queue() Cindy Lu
2024-08-27 2:36 ` Jason Wang
2024-08-28 9:32 ` Cindy Lu
2024-08-19 9:27 ` Cindy Lu [this message]
2024-08-19 9:27 ` [RFC 4/7] vhost: Add the vhost_worker to support kthread Cindy Lu
2024-08-19 9:27 ` [RFC 5/7] vhost: Add the cgroup related function Cindy Lu
2024-08-19 9:27 ` [RFC 6/7] vhost: Add kthread support in function vhost_worker_create Cindy Lu
2024-08-19 9:27 ` [RFC 7/7] vhost: Add new UAPI to support changing Kthread mode Cindy Lu
2024-08-21 5:06 ` Christoph Hellwig
2024-08-25 13:51 ` Cindy Lu
2024-08-26 6:21 ` Jason Wang
2024-08-26 6:26 ` Christoph Hellwig
2024-08-27 2:09 ` Jason Wang
2024-08-27 2:30 ` Jason Wang
2024-08-27 2:32 ` Jason Wang
2024-08-28 9:46 ` Cindy Lu
2024-08-27 2:36 ` Jason Wang
2024-08-27 2:35 ` [RFC 0/7] vhost: Add support of kthread API Jason Wang
2024-08-28 9:47 ` Cindy Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240819092851.441670-4-lulu@redhat.com \
--to=lulu@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®