From: Cindy Lu <lulu@redhat.com>
To: lulu@redhat.com, jasowang@redhat.com, mst@redhat.com,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: [RFC 5/7] vhost: Add the cgroup related function
Date: Mon, 19 Aug 2024 17:27:31 +0800 [thread overview]
Message-ID: <20240819092851.441670-6-lulu@redhat.com> (raw)
In-Reply-To: <20240819092851.441670-1-lulu@redhat.com>
Add back the previously removed cgroup function to support the kthread
The biggest change for this part is in vhost_attach_cgroups() and
vhost_worker_cgroups_kthread(). This is because of the change in
struct dev->worker_xa.
Signed-off-by: Cindy Lu <lulu@redhat.com>
---
drivers/vhost/vhost.c | 52 +++++++++++++++++++++++++++++++++++++++++++
1 file changed, 52 insertions(+)
diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index 593f9521f51d..66ccda81f073 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -22,6 +22,7 @@
#include <linux/slab.h>
#include <linux/vmalloc.h>
#include <linux/kthread.h>
+#include <linux/cgroup.h>
#include <linux/module.h>
#include <linux/sort.h>
#include <linux/sched/mm.h>
@@ -648,6 +649,57 @@ long vhost_dev_check_owner(struct vhost_dev *dev)
}
EXPORT_SYMBOL_GPL(vhost_dev_check_owner);
+struct vhost_attach_cgroups_struct {
+ struct vhost_work work;
+ struct task_struct *owner;
+ int ret;
+};
+
+static void vhost_attach_cgroups_work(struct vhost_work *work)
+{
+ struct vhost_attach_cgroups_struct *s;
+
+ s = container_of(work, struct vhost_attach_cgroups_struct, work);
+ s->ret = cgroup_attach_task_all(s->owner, current);
+}
+
+static int vhost_worker_cgroups_kthread(struct vhost_worker *worker)
+{
+ struct vhost_flush_struct flush;
+ struct vhost_attach_cgroups_struct attach;
+
+ attach.owner = current;
+
+ vhost_work_init(&attach.work, vhost_attach_cgroups_work);
+ vhost_worker_queue(worker, &attach.work);
+
+ init_completion(&flush.wait_event);
+ vhost_work_init(&flush.work, vhost_flush_work);
+ vhost_worker_queue(worker, &flush.work);
+ wait_for_completion(&flush.wait_event);
+
+ return attach.ret;
+}
+
+static int vhost_attach_cgroups(struct vhost_dev *dev)
+{
+ struct vhost_worker *worker;
+ unsigned long i;
+ int ret;
+
+ /*
+ * Free the default worker we created and cleanup workers userspace
+ * created but couldn't clean up (it forgot or crashed).
+ */
+
+ xa_for_each(&dev->worker_xa, i, worker) {
+ ret = vhost_worker_cgroups_kthread(worker);
+ if (ret)
+ return ret;
+ }
+ return ret;
+}
+
/* Caller should have device mutex */
bool vhost_dev_has_owner(struct vhost_dev *dev)
{
--
2.45.0
next prev parent reply other threads:[~2024-08-19 9:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 9:27 [RFC 0/7] vhost: Add support of kthread API Cindy Lu
2024-08-19 9:27 ` [RFC 1/7] vhost: Add a new module_param for enable kthread Cindy Lu
2024-08-19 9:27 ` [RFC 2/7] vhost: Add kthread support in function vhost_worker_queue() Cindy Lu
2024-08-27 2:36 ` Jason Wang
2024-08-28 9:32 ` Cindy Lu
2024-08-19 9:27 ` [RFC 3/7] vhost: Add kthread support in function vhost_workers_free() Cindy Lu
2024-08-19 9:27 ` [RFC 4/7] vhost: Add the vhost_worker to support kthread Cindy Lu
2024-08-19 9:27 ` Cindy Lu [this message]
2024-08-19 9:27 ` [RFC 6/7] vhost: Add kthread support in function vhost_worker_create Cindy Lu
2024-08-19 9:27 ` [RFC 7/7] vhost: Add new UAPI to support changing Kthread mode Cindy Lu
2024-08-21 5:06 ` Christoph Hellwig
2024-08-25 13:51 ` Cindy Lu
2024-08-26 6:21 ` Jason Wang
2024-08-26 6:26 ` Christoph Hellwig
2024-08-27 2:09 ` Jason Wang
2024-08-27 2:30 ` Jason Wang
2024-08-27 2:32 ` Jason Wang
2024-08-28 9:46 ` Cindy Lu
2024-08-27 2:36 ` Jason Wang
2024-08-27 2:35 ` [RFC 0/7] vhost: Add support of kthread API Jason Wang
2024-08-28 9:47 ` Cindy Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240819092851.441670-6-lulu@redhat.com \
--to=lulu@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®