mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] scripts/get_abi.pl: more strict matching of [XYZ]
@ 2024-08-20 16:40 David Lechner
  2024-08-20 17:57 ` Nathan Chancellor
  0 siblings, 1 reply; 2+ messages in thread
From: David Lechner @ 2024-08-20 16:40 UTC (permalink / raw)
  To: linux-kbuild
  Cc: Masahiro Yamada, Nathan Chancellor, Nicolas Schier,
	Mauro Carvalho Chehab, linux-kernel, David Lechner

When using `scripts/get_abi.pl undefined --search-string=iio` to try to
find undocumented ABI's in the IIO subsystem, no matches were found.

This was due to the fact that we have documented a directory naming
pattern:

	What: /sys/bus/iio/devices/iio:deviceX

which gets translated to the regex

	/sys/.*/iio\:device.*

which matches everything under every iio:device directory, causing any
attributes below this directory to incorrectly be filtered out as
already documented.

This patch makes the matching more strict by changing the replacement
for [XYZ] from .* to [^/]* so that we don't match the directory
separator. This way documenting directories won't filter out everything
contained in the directory as already being documented.

Signed-off-by: David Lechner <dlechner@baylibre.com>
---
get_maintainers.pl didn't pick up any matches for this patch, so I guess
this would go through the kbuild tree? (Since MAINTAINERS says:
"KERNEL BUILD + files below scripts/ (unless maintained elsewhere)")
---
 scripts/get_abi.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/get_abi.pl b/scripts/get_abi.pl
index de1c0354b50c..f65158694852 100755
--- a/scripts/get_abi.pl
+++ b/scripts/get_abi.pl
@@ -867,7 +867,7 @@ sub undefined_symbols {
 			$what =~ s/\{[^\}]+\}/.*/g;
 			$what =~ s/\[[^\]]+\]/.*/g;
 
-			$what =~ s/[XYZ]/.*/g;
+			$what =~ s/[XYZ]/[^\/]*/g;
 
 			# Recover [0-9] type of patterns
 			$what =~ s/\xf4/[/g;

---
base-commit: 521b1e7f4cf0b05a47995b103596978224b380a8
change-id: 20240820-scripts-fix-get_abi-xyz-0ab0b9b62719

Best regards,
-- 
David Lechner <dlechner@baylibre.com>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-08-20 17:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-20 16:40 [PATCH] scripts/get_abi.pl: more strict matching of [XYZ] David Lechner
2024-08-20 17:57 ` Nathan Chancellor

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®