From: Ye Zhang <ye.zhang@rock-chips.com>
To: linus.walleij@linaro.org, brgl@bgdev.pl, heiko@sntech.de,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
mika.westerberg@linux.intel.com,
andriy.shevchenko@linux.intel.com, tao.huang@rock-chips.com,
finley.xiao@rock-chips.com, tim.chen@rock-chips.com,
elaine.zhang@rock-chips.com, Ye Zhang <ye.zhang@rock-chips.com>
Subject: [PATCH v2] gpio: rockchip: Update debounce config function
Date: Fri, 23 Aug 2024 11:43:09 +0800 [thread overview]
Message-ID: <20240823034314.62305-7-ye.zhang@rock-chips.com> (raw)
In-Reply-To: <20240823034314.62305-1-ye.zhang@rock-chips.com>
In the GPIO with version number 0x01000C2B, debounce configuration is
already supported.
Signed-off-by: Ye Zhang <ye.zhang@rock-chips.com>
---
drivers/gpio/gpio-rockchip.c | 17 ++++-------------
1 file changed, 4 insertions(+), 13 deletions(-)
diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
index c246f116a3b5..aff8bec79062 100644
--- a/drivers/gpio/gpio-rockchip.c
+++ b/drivers/gpio/gpio-rockchip.c
@@ -250,6 +250,8 @@ static int rockchip_gpio_set_debounce(struct gpio_chip *gc,
clk_prepare_enable(bank->db_clk);
else
clk_disable_unprepare(bank->db_clk);
+ } else {
+ return -ENOTSUPP;
}
return 0;
@@ -278,22 +280,11 @@ static int rockchip_gpio_set_config(struct gpio_chip *gc, unsigned int offset,
unsigned long config)
{
enum pin_config_param param = pinconf_to_config_param(config);
+ unsigned int debounce = pinconf_to_config_argument(config);
switch (param) {
case PIN_CONFIG_INPUT_DEBOUNCE:
- rockchip_gpio_set_debounce(gc, offset, true);
- /*
- * Rockchip's gpio could only support up to one period
- * of the debounce clock(pclk), which is far away from
- * satisftying the requirement, as pclk is usually near
- * 100MHz shared by all peripherals. So the fact is it
- * has crippled debounce capability could only be useful
- * to prevent any spurious glitches from waking up the system
- * if the gpio is conguired as wakeup interrupt source. Let's
- * still return -ENOTSUPP as before, to make sure the caller
- * of gpiod_set_debounce won't change its behaviour.
- */
- return -ENOTSUPP;
+ return rockchip_gpio_set_debounce(gc, offset, debounce);
default:
return -ENOTSUPP;
}
--
2.34.1
next prev parent reply other threads:[~2024-08-23 15:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 3:43 [PATCH v2] gpio: rockchip: Update the GPIO driver Ye Zhang
2024-08-23 3:43 ` [PATCH v2] gpio: rockchip: avoid division by zero Ye Zhang
2024-08-23 9:27 ` Heiko Stübner
2024-08-23 14:45 ` Andy Shevchenko
2024-08-23 3:43 ` [PATCH v2] gpio: rockchip: release reference to device node Ye Zhang
2024-08-23 9:28 ` Heiko Stübner
2024-08-23 10:52 ` Shawn Lin
2024-08-23 3:43 ` [PATCH v2] gpio: rockchip: resolve overflow issues Ye Zhang
2024-08-23 9:34 ` Heiko Stübner
2024-08-23 10:59 ` Shawn Lin
2024-08-23 14:49 ` Andy Shevchenko
2024-08-23 14:48 ` Andy Shevchenko
2024-08-23 3:43 ` [PATCH v2] gpio: rockchip: resolve underflow issue Ye Zhang
2024-08-23 14:51 ` Andy Shevchenko
2024-08-23 3:43 ` [PATCH v2] gpio: rockchip: fix debounce calculate Ye Zhang
2024-08-23 3:43 ` Ye Zhang [this message]
2024-08-23 3:43 ` [PATCH v2] gpio: rockchip: support 'clock-names' from dt nodes Ye Zhang
2024-08-23 14:56 ` Andy Shevchenko
2024-08-23 3:43 ` [PATCH v2] gpio: rockchip: support new version gpio Ye Zhang
2024-08-23 13:32 ` Sebastian Reichel
2024-08-23 15:05 ` Andy Shevchenko
2024-08-23 3:43 ` [PATCH v2] gpio: rockchip: Set input direction when request irq Ye Zhang
2024-08-23 14:59 ` Andy Shevchenko
2024-08-23 3:43 ` [PATCH v2] gpio: rockchip: support ACPI Ye Zhang
2024-08-23 5:27 ` Mika Westerberg
2024-08-23 7:03 ` [PATCH v2] gpio: rockchip: Update the GPIO driver Bartosz Golaszewski
2024-08-23 7:06 ` Dragan Simic
2024-08-23 15:07 ` Andy Shevchenko
2024-08-23 9:33 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240823034314.62305-7-ye.zhang@rock-chips.com \
--to=ye.zhang@rock-chips.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=elaine.zhang@rock-chips.com \
--cc=finley.xiao@rock-chips.com \
--cc=heiko@sntech.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mika.westerberg@linux.intel.com \
--cc=tao.huang@rock-chips.com \
--cc=tim.chen@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®