* [PATCH] hwmon: stts751: Add "st" vendor prefix to "stts751" compatible string
@ 2024-08-26 19:18 Rob Herring (Arm)
2024-08-27 3:55 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring (Arm) @ 2024-08-26 19:18 UTC (permalink / raw)
To: Jean Delvare, Guenter Roeck; +Cc: linux-hwmon, linux-kernel
The documented compatible string is "st,stts751", not "stts751". Even if
"stts751" was in use, there's no need to list "stts751" in the DT match
table. The I2C core will strip any vendor prefix and match against the
i2c_device_id table which has an "stts751" entry.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
drivers/hwmon/stts751.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/stts751.c b/drivers/hwmon/stts751.c
index e7632081a1d1..f9e8b2869164 100644
--- a/drivers/hwmon/stts751.c
+++ b/drivers/hwmon/stts751.c
@@ -77,7 +77,7 @@ static const struct i2c_device_id stts751_id[] = {
};
static const struct of_device_id __maybe_unused stts751_of_match[] = {
- { .compatible = "stts751" },
+ { .compatible = "st,stts751" },
{ },
};
MODULE_DEVICE_TABLE(of, stts751_of_match);
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] hwmon: stts751: Add "st" vendor prefix to "stts751" compatible string
2024-08-26 19:18 [PATCH] hwmon: stts751: Add "st" vendor prefix to "stts751" compatible string Rob Herring (Arm)
@ 2024-08-27 3:55 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2024-08-27 3:55 UTC (permalink / raw)
To: Rob Herring (Arm); +Cc: Jean Delvare, linux-hwmon, linux-kernel
On Mon, Aug 26, 2024 at 02:18:11PM -0500, Rob Herring (Arm) wrote:
> The documented compatible string is "st,stts751", not "stts751". Even if
> "stts751" was in use, there's no need to list "stts751" in the DT match
> table. The I2C core will strip any vendor prefix and match against the
> i2c_device_id table which has an "stts751" entry.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Applied.
Thanks,
Guenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-27 3:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-26 19:18 [PATCH] hwmon: stts751: Add "st" vendor prefix to "stts751" compatible string Rob Herring (Arm)
2024-08-27 3:55 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®