mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chen-Yu Tsai <wenst@chromium.org>
To: Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>
Cc: Chen-Yu Tsai <wenst@chromium.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v2 00/10] regulator: kerneldoc section fixes
Date: Thu, 29 Aug 2024 16:51:20 +0800	[thread overview]
Message-ID: <20240829085131.1361701-1-wenst@chromium.org> (raw)

Hi,

This is v2 of my regulator kerneldoc fixes series. The series sort of
came as a request from Andy to not move code that already had warnings
without fixing said warnings. So here I'm fixing them first.

Changes since v1:
- Replaced "true, false" with "valid return values" in commit message of
  "Fix regulator_is_supported_voltage() kerneldoc return value".
- Added articles ("the", "a") to the description based on surrounding
  and function implementation context.
  - The indefinite article ("a", "an") is used when the return value can
    vary in the case of negative error numbers or when the returned
    pointer points to a newly allocated memory object.
  - The definite article ("the") is used when a specific return value is
    mentioned, or when the returned pointer points to some existing object.
- Capitalized first word of first sentence in "Return" section.
- Indented "Return" section for regulator_is_enabled().
- s/alloc/allocation/
- s/error code/error number/
- For patch 'regulator: irq_helpers: Add missing "Return" kerneldoc section':
  - Changed subject to "Fix regulator_irq_map_event_simple() kerneldoc".
  - Described output fields in @rid clearly.
- Added patch to fix of_regulator_bulk_get_all() kerneldoc.
- Added patch to align "negative error number" terminology.

Link to v1:
https://lore.kernel.org/all/20240827095550.675018-1-wenst@chromium.org/

The bulk of the fixes are in the regulator core and OF code, but I also
fixed up a few bits in common code that were missing "Return" sections.
There's also a final patch to align terminology around "negative error
number" within the regulator subsystem. These are purely kerneldoc and
comment fixes and don't touch any actual code. I left the devres code
and helpers alone for now.

The patch series is based on next-20240829. Please merge if possible.
I will rebase my I2C OF component prober series [1] on top of them.

Thanks
ChenYu

[1] https://lore.kernel.org/all/20240822092006.3134096-1-wenst@chromium.org/

Chen-Yu Tsai (10):
  regulator: core: Fix short description for
    _regulator_check_status_enabled()
  regulator: core: Fix regulator_is_supported_voltage() kerneldoc return
    value
  regulator: core: Fix incorrectly formatted kerneldoc "Return" sections
  regulator: core: Add missing kerneldoc "Return" sections
  regulator: of: Fix incorrectly formatted kerneldoc "Return" sections
  regulator: fixed: Fix incorrectly formatted kerneldoc "Return" section
  regulator: fixed-helper: Add missing "Return" kerneldoc section
  regulator: irq_helpers: Fix regulator_irq_map_event_simple() kerneldoc
  regulator: of: Fix kerneldoc format for of_regulator_bulk_get_all()
  regulator: Unify "negative error number" terminology in comments

 drivers/regulator/core.c                | 178 +++++++++++++++++-------
 drivers/regulator/devres.c              |  18 +--
 drivers/regulator/fixed-helper.c        |   2 +
 drivers/regulator/fixed.c               |   8 +-
 drivers/regulator/irq_helpers.c         |  17 ++-
 drivers/regulator/max77802-regulator.c  |   4 +-
 drivers/regulator/of_regulator.c        |  21 +--
 drivers/regulator/qcom-rpmh-regulator.c |   6 +-
 drivers/regulator/qcom_smd-regulator.c  |   2 +-
 9 files changed, 170 insertions(+), 86 deletions(-)

-- 
2.46.0.295.g3b9ea8a38a-goog


             reply	other threads:[~2024-08-29  8:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-29  8:51 Chen-Yu Tsai [this message]
2024-08-29  8:51 ` [PATCH v2 01/10] regulator: core: Fix short description for _regulator_check_status_enabled() Chen-Yu Tsai
2024-08-29  8:51 ` [PATCH v2 02/10] regulator: core: Fix regulator_is_supported_voltage() kerneldoc return value Chen-Yu Tsai
2024-08-29 12:46   ` Andy Shevchenko
2024-08-29 22:59     ` Chen-Yu Tsai
2024-08-29  8:51 ` [PATCH v2 03/10] regulator: core: Fix incorrectly formatted kerneldoc "Return" sections Chen-Yu Tsai
2024-08-29  8:51 ` [PATCH v2 04/10] regulator: core: Add missing " Chen-Yu Tsai
2024-08-29  8:51 ` [PATCH v2 05/10] regulator: of: Fix incorrectly formatted " Chen-Yu Tsai
2024-08-29 12:48   ` Andy Shevchenko
2024-08-29  8:51 ` [PATCH v2 06/10] regulator: fixed: Fix incorrectly formatted kerneldoc "Return" section Chen-Yu Tsai
2024-08-29  8:51 ` [PATCH v2 07/10] regulator: fixed-helper: Add missing "Return" kerneldoc section Chen-Yu Tsai
2024-08-29  8:51 ` [PATCH v2 08/10] regulator: irq_helpers: Fix regulator_irq_map_event_simple() kerneldoc Chen-Yu Tsai
2024-08-29 12:49   ` Andy Shevchenko
2024-08-29  8:51 ` [PATCH v2 09/10] regulator: of: Fix kerneldoc format for of_regulator_bulk_get_all() Chen-Yu Tsai
2024-08-29  8:51 ` [PATCH v2 10/10] regulator: Unify "negative error number" terminology in comments Chen-Yu Tsai
2024-08-29 12:54 ` [PATCH v2 00/10] regulator: kerneldoc section fixes Andy Shevchenko
2024-08-29 16:07 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240829085131.1361701-1-wenst@chromium.org \
    --to=wenst@chromium.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®