From: Chen-Yu Tsai <wenst@chromium.org>
To: Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>
Cc: Chen-Yu Tsai <wenst@chromium.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Matti Vaittinen <mazziesaccount@gmail.com>
Subject: [PATCH v2 08/10] regulator: irq_helpers: Fix regulator_irq_map_event_simple() kerneldoc
Date: Thu, 29 Aug 2024 16:51:28 +0800 [thread overview]
Message-ID: <20240829085131.1361701-9-wenst@chromium.org> (raw)
In-Reply-To: <20240829085131.1361701-1-wenst@chromium.org>
kernel-doc complains about missing "Return" section for the function
regulator_irq_map_event_simple().
Add a "Return" section for it based on its behavior. The function
actually always returns 0, but fills in fields in its @rid parameter as
needed. Expand the description of the parameter to cover this.
While at it fix a typo found in the description of the same function.
Reported-by: Matti Vaittinen <mazziesaccount@gmail.com>
Closes: https://lore.kernel.org/all/e341240e-1c1f-49a2-91cd-440888fdbda0@gmail.com/
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
Changes since v1:
- Update commit subject to reflect changes
- Was 'regulator: irq_helpers: Add missing "Return" kerneldoc section'
- Add period ('.') to the end of the "Return" section sentence
- Fix typo in function description spotted by Marti
- Describe output fields in @rid clearly
---
drivers/regulator/irq_helpers.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/regulator/irq_helpers.c b/drivers/regulator/irq_helpers.c
index 5ab1a0befe12..2de7b907c81d 100644
--- a/drivers/regulator/irq_helpers.c
+++ b/drivers/regulator/irq_helpers.c
@@ -404,16 +404,21 @@ EXPORT_SYMBOL_GPL(regulator_irq_helper_cancel);
/**
* regulator_irq_map_event_simple - regulator IRQ notification for trivial IRQs
*
- * @irq: Number of IRQ that occurred
- * @rid: Information about the event IRQ indicates
- * @dev_mask: mask indicating the regulator originating the IRQ
+ * @irq: Number of IRQ that occurred.
+ * @rid: Information about the event IRQ indicates.
+ * The function fills in the ®ulator_err_state->notifs
+ * and ®ulator_err_state->errors fields of
+ * ®ulator_irq_data->states as output.
+ * @dev_mask: mask indicating the regulator originating the IRQ.
*
* Regulators whose IRQ has single, well defined purpose (always indicate
* exactly one event, and are relevant to exactly one regulator device) can
- * use this function as their map_event callbac for their regulator IRQ
- * notification helperk. Exactly one rdev and exactly one error (in
+ * use this function as their map_event callback for their regulator IRQ
+ * notification helper. Exactly one rdev and exactly one error (in
* "common_errs"-field) can be given at IRQ helper registration for
* regulator_irq_map_event_simple() to be viable.
+ *
+ * Return: 0.
*/
int regulator_irq_map_event_simple(int irq, struct regulator_irq_data *rid,
unsigned long *dev_mask)
--
2.46.0.295.g3b9ea8a38a-goog
next prev parent reply other threads:[~2024-08-29 8:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 8:51 [PATCH v2 00/10] regulator: kerneldoc section fixes Chen-Yu Tsai
2024-08-29 8:51 ` [PATCH v2 01/10] regulator: core: Fix short description for _regulator_check_status_enabled() Chen-Yu Tsai
2024-08-29 8:51 ` [PATCH v2 02/10] regulator: core: Fix regulator_is_supported_voltage() kerneldoc return value Chen-Yu Tsai
2024-08-29 12:46 ` Andy Shevchenko
2024-08-29 22:59 ` Chen-Yu Tsai
2024-08-29 8:51 ` [PATCH v2 03/10] regulator: core: Fix incorrectly formatted kerneldoc "Return" sections Chen-Yu Tsai
2024-08-29 8:51 ` [PATCH v2 04/10] regulator: core: Add missing " Chen-Yu Tsai
2024-08-29 8:51 ` [PATCH v2 05/10] regulator: of: Fix incorrectly formatted " Chen-Yu Tsai
2024-08-29 12:48 ` Andy Shevchenko
2024-08-29 8:51 ` [PATCH v2 06/10] regulator: fixed: Fix incorrectly formatted kerneldoc "Return" section Chen-Yu Tsai
2024-08-29 8:51 ` [PATCH v2 07/10] regulator: fixed-helper: Add missing "Return" kerneldoc section Chen-Yu Tsai
2024-08-29 8:51 ` Chen-Yu Tsai [this message]
2024-08-29 12:49 ` [PATCH v2 08/10] regulator: irq_helpers: Fix regulator_irq_map_event_simple() kerneldoc Andy Shevchenko
2024-08-29 8:51 ` [PATCH v2 09/10] regulator: of: Fix kerneldoc format for of_regulator_bulk_get_all() Chen-Yu Tsai
2024-08-29 8:51 ` [PATCH v2 10/10] regulator: Unify "negative error number" terminology in comments Chen-Yu Tsai
2024-08-29 12:54 ` [PATCH v2 00/10] regulator: kerneldoc section fixes Andy Shevchenko
2024-08-29 16:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240829085131.1361701-9-wenst@chromium.org \
--to=wenst@chromium.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®